fix: redirect on action when no_confirmation = true

app/javascript/js/controllers/action_controller.js

@@ -2,7 +2,7 @@ import { Controller } from '@hotwired/stimulus'
 import { castBoolean } from '../helpers/cast_boolean'
 
 export default class extends Controller {
-  static targets = ['controllerDiv', 'resourceIds', 'form', 'selectedAllQuery']
+  static targets = ['controllerDiv', 'resourceIds', 'submit', 'selectedAllQuery']
 
   connect() {
     this.resourceIdsTarget.value = this.resourceIds
@@ -13,7 +13,7 @@ export default class extends Controller {
     }
 
     if (this.noConfirmation) {
-      this.formTarget.submit()
+      this.submitTarget.click()
     } else {
       this.controllerDivTarget.classList.remove('hidden')
     }

lib/avo/base_action.rb

@@ -32,19 +32,21 @@ class << self
       def form_data_attributes
         # We can't respond with a file download from Turbo se we disable it on the form
         if may_download_file
-          {turbo: turbo || false, remote: false, action_target: :form}
+          {turbo: turbo || false, remote: false}
         else
-          {turbo: turbo, turbo_frame: :_top, action_target: :form}.compact
+          {turbo: turbo, turbo_frame: :_top}.compact
         end
       end
 
       # We can't respond with a file download from Turbo se we disable close the modal manually after a while (it's a hack, we know)
       def submit_button_data_attributes
+        attributes = { action_target: "submit" }
+
         if may_download_file
-          {action: "click->modal#delayedClose"}
-        else
-          {}
+          attributes[:action] = "click->modal#delayedClose"
         end
+
+        attributes
       end
     end
 

spec/system/avo/actions_spec.rb

@@ -131,6 +131,35 @@
     end
   end
 
+  describe "redirects when no confirmation" do
+    it "redirects to hey page" do
+      no_confirmation = Sub::DummyAction.no_confirmation
+
+      Sub::DummyAction.class_eval do
+        self.no_confirmation = true
+
+        define_method(:redirect_handle) do |**args|
+          redirect_to main_app.hey_path
+        end
+
+        alias_method :handle, :redirect_handle
+      end
+
+      visit "/admin/resources/users"
+
+      click_on "Actions"
+      click_on "Dummy action"
+
+      expect(page).to have_text "hey en"
+
+
+      Sub::DummyAction.class_eval do
+        undef_method :redirect_handle
+      end
+
+      Sub::DummyAction.no_confirmation = no_confirmation
+    end
+  end
   #   let!(:roles) { { admin: false, manager: false, writer: false } }
   #   let!(:user) { create :user, active: true, roles: roles }