Remove type alias for Action + Auth + Output Registry #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-kim
force-pushed
the
alias
branch
2 times, most recently
from
6cd9ed2
to
1c1ad9d
Compare
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
joshua-kim
commented
Oct 2, 2024
| ActionRegistry() chain.ActionRegistry | ||
| OutputRegistry() chain.OutputRegistry | ||
| AuthRegistry() chain.AuthRegistry | ||
| ActionCodec() *codec.TypeParser[chain.Action] |
There was a problem hiding this comment.
Not sure if we should name this ActionRegistry or ActionParser or ActionCodec?
joshua-kim
changed the title
Signed-off-by: Joshua Kim <[email protected]>
joshua-kim
commented
Oct 2, 2024
| @@ -151,9 +151,8 @@ type GetABIReply struct { | |||
| } | |||
|
|
|||
| func (j *JSONRPCServer) GetABI(_ *http.Request, _ *GetABIArgs, reply *GetABIReply) error { | |||
| actionRegistry, outputRegistry := j.vm.ActionRegistry(), j.vm.OutputRegistry() | |||
| // Must dereference aliased type to call GetRegisteredTypes | |||
| vmABI, err := abi.NewABI((*actionRegistry).GetRegisteredTypes(), (*outputRegistry).GetRegisteredTypes()) | |||
There was a problem hiding this comment.
Motivation behind the PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: https://github.com/ava-labs/hypersdk/pull/1459/files#r1757172327