Skip to content

Commit

Permalink
nit
Browse files Browse the repository at this point in the history
Signed-off-by: Joshua Kim <[email protected]>
  • Loading branch information
joshua-kim committed Sep 20, 2024
1 parent 15147a6 commit 9c1499b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
5 changes: 2 additions & 3 deletions api/jsonrpc/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,7 @@ type GetABIReply struct {

func (j *JSONRPCServer) GetABI(_ *http.Request, _ *GetABIArgs, reply *GetABIReply) error {
actionRegistry, outputRegistry := j.vm.ActionRegistry(), j.vm.OutputRegistry()
// Must dereference aliased type to call GetRegisteredTypes
vmABI, err := abi.NewABI((*actionRegistry).GetRegisteredTypes(), (*outputRegistry).GetRegisteredTypes())
vmABI, err := abi.NewABI(actionRegistry.GetRegisteredTypes(), (*outputRegistry).GetRegisteredTypes())
if err != nil {
return err
}
Expand All @@ -180,7 +179,7 @@ func (j *JSONRPCServer) Execute(
defer span.End()

actionRegistry := j.vm.ActionRegistry()
action, err := (*actionRegistry).Unmarshal(codec.NewReader(args.Action, len(args.Action)))
action, err := actionRegistry.Unmarshal(codec.NewReader(args.Action, len(args.Action)))
if err != nil {
return fmt.Errorf("failed to unmashal action: %w", err)
}
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/integration.go
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ var _ = ginkgo.Describe("[HyperSDK APIs]", func() {
ginkgo.By("Gets ABI")

actionRegistry, outputRegistry := instances[0].vm.ActionRegistry(), instances[0].vm.OutputRegistry()
expectedABI, err := abi.NewABI((*actionRegistry).GetRegisteredTypes(), (*outputRegistry).GetRegisteredTypes())
expectedABI, err := abi.NewABI(actionRegistry.GetRegisteredTypes(), (*outputRegistry).GetRegisteredTypes())
require.NoError(err)

workload.GetABI(ctx, require, uris, expectedABI)
Expand Down

0 comments on commit 9c1499b

Please sign in to comment.