Return Option<T> instead of erroring with api::Error:::KeyNotFound #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of returning an Error when a key is not found, an Option will be returned. This PR also modifies all the other functions inside the `api::DbView`, maybe only `val` should be updated at this stage.
nytzuga
commented
Jul 28, 2023
| assert_eq!(proposal3.val(b"k").await.unwrap(), b"v"); | ||
| assert_eq!(proposal3.val(b"z").await.unwrap(), b"undo"); | ||
| assert_eq!(proposal3.val(b"k").await.unwrap().unwrap(), b"v"); | ||
| assert_eq!(proposal3.val(b"z").await.unwrap().unwrap(), b"undo"); |
There was a problem hiding this comment.
I just follow the pattern, but if it was up to me I would just change it to assert_eq!(proposal3.val(b"z").await, Ok(Some(b"undo")));.
Also, it think it would be nice to use bytes::Bytes instead of raw Vec<u8> (
There was a problem hiding this comment.
We eventually will be returning a reference instead of an owned value, but we want to get something out soon so we're sticking with owned for now and will change that later.
There was a problem hiding this comment.
The beauty of bytes::Bytes is that you can return the ownership but the memory segment is referenced counted internally[1].
People are free to copy into a bytes::BytesMut to modify, but bytes::Bytes are read only.
xinifinity
approved these changes
Jul 28, 2023
nytzuga
changed the title
rkuris
approved these changes
Jul 28, 2023
rkuris
changed the title
rkuris
pushed a commit
that referenced
this pull request
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of returning an Error when a key is not found, an Option will be returned.
This PR also modifies all the other functions inside the
api::DbView, maybe onlyvalshould be updated at this stage.