Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove api::Error:::KeyNotFound and use Option<ValueType> for val #168

Closed
rkuris opened this issue Jul 26, 2023 · 1 comment
Closed

Remove api::Error:::KeyNotFound and use Option<ValueType> for val #168

rkuris opened this issue Jul 26, 2023 · 1 comment
Labels
good first issue Good for newcomers

Comments

@rkuris
Copy link
Collaborator

rkuris commented Jul 26, 2023 •
edited
Loading

This change involves modifying firewood/src/v2/api.rs to remove api::Error::KeyNotFound and change the val method to return Option<ValueType> when the value is not found.
@rkuris rkuris mentioned this issue Jul 26, 2023
Merged
@rkuris rkuris added the good first issue Good for newcomers label Jul 26, 2023
@nytzuga
Copy link
Contributor

nytzuga commented Jul 28, 2023

Fixed in #171

@nytzuga nytzuga closed this as completed Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rkuris @nytzuga