Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(.github): rename bake-target to target-image and add descriptions to args #5413

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Nov 8, 2024

Description

Based on @wenrir's #5363 (comment), this PR renamed bake-target to target-image and also added explanations for the arguments in action.yaml files.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@youtalk youtalk self-assigned this Nov 8, 2024
@youtalk youtalk added type:github-actions Github actions related. (auto-assigned) tag:run-health-check Run health-check labels Nov 8, 2024
@youtalk youtalk marked this pull request as ready for review November 8, 2024 02:42
Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk youtalk requested a review from xmfcx November 11, 2024 12:24
@youtalk youtalk enabled auto-merge (squash) November 11, 2024 12:24
@youtalk youtalk requested a review from xmfcx November 11, 2024 12:33
Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@youtalk youtalk merged commit a0d3fca into main Nov 11, 2024
14 checks passed
@youtalk youtalk deleted the target-image branch November 11, 2024 13:29
@youtalk youtalk mentioned this pull request Nov 12, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:run-health-check Run health-check type:github-actions Github actions related. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants