build(autoware.repos): remove ament_cmake fork repository #5360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChgygLin
changed the title
ChgygLin
changed the title
ChgygLin
changed the title
Signed-off-by: Chengyong Lin <[email protected]>
|
I see, also the humble backport PR was merged in 2024-07-16 too: |
xmfcx
changed the title
(^_^) |
youtalk
added a commit
to youtalk/autoware
that referenced
this pull request
Nov 8, 2024
* chore(docker): remove `/autoware/log` after `colcon build` (autowarefoundation#5329) * chore(.github): always run `Show disk space` (autowarefoundation#5354) always show disk space Signed-off-by: Yutaka Kondo <[email protected]> * build(autoware.repos): remove ament_cmake fork repository (autowarefoundation#5360) Signed-off-by: Chengyong Lin <[email protected]> * fix: remove `ndt_omp` (autowarefoundation#5390) Removed ndt_omp Signed-off-by: Shintaro Sakoda <[email protected]> * fix: change the organization of `awsim_sensor_kit_launch` from RobotecAI to tier4 (autowarefoundation#5403) Fixed organization of `awsim_sensor_kit_launch` from RobotecAI to tier4 Signed-off-by: Shintaro Sakoda <[email protected]> * chore(.devcontainer): rename `.devcontainer` directories (autowarefoundation#5407) rename .devcontainer dirs Signed-off-by: Yutaka Kondo <[email protected]> * feat(docker): integrate `cuda`/`no-cuda` jobs into single job (autowarefoundation#5363) --------- Signed-off-by: Yutaka Kondo <[email protected]> Signed-off-by: Chengyong Lin <[email protected]> Signed-off-by: Shintaro Sakoda <[email protected]> Co-authored-by: chgyg <[email protected]> Co-authored-by: SakodaShintaro <[email protected]> Co-authored-by: SakodaShintaro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When I compiled the Autoware repository, several warnings appeared.
WARNING:colcon.colcon_core.package_selection:Some selected packages are already built in one or more underlay workspaces: 'ament_cmake_core' is in: /opt/ros/humble ...I found the
ament_cmakehas a local version insrc/universe/external/ament_cmake, and ROS-humble also has another version.After a period of investigation, I found the following comment in the file
autoware.reposuniverse/external/ament_cmake: # TODO(mitsudome-r): remove when https://github.com/ament/ament_cmake/pull/448 is merged.The ament_cmake pr/448 has been merged on Mar 30, so the
ament_cmakelocal version may need to be removed.Tests performed
I checked the changed files by ament_cmake pr/448, the current ROS-humble distribution has already merged this modification.
/opt/ros/humble/share/ament_cmake_libraries/cmake/ament_libraries_deduplicate.cmake/opt/ros/humble/share/ament_cmake_libraries/cmake/ament_cmake_libraries-extras.cmake.Effects on system behavior
The compilation warnings have been eliminated.
Interface changes
Nothing changed.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.