Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): copy all .csv and .png files to images #5263

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Sep 20, 2024

Description

Fixed #5180

The previous PR #5187 couldn't fix the issue #5180.
This PR copies all .csv and .png files to images.
It affects the image size, but for now, I prioritize solving the issue. I would like to minimize the amount of copying in a separate PR.

Tests performed

youtalk#114
https://github.com/youtalk/autoware/actions/runs/10953443398

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@youtalk youtalk self-assigned this Sep 20, 2024
@youtalk youtalk added type:containers Docker containers, containerization of components, or container orchestration. component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check labels Sep 20, 2024
@youtalk youtalk marked this pull request as ready for review September 20, 2024 06:48
@youtalk
Copy link
Member Author

youtalk commented Sep 20, 2024

@yvzksgl I think it finally works.

docker run --rm -it youtalk/autoware:universe-devel-cuda-amd64
root@4b1915e23afc:/autoware# ls /opt/autoware/share/autoware_overlay_rviz_plugin/assets/images/
arrow.png  select_add.png  select_topic_name.png  traffic.png  wheel.png
root@4b1915e23afc:/autoware# ls /opt/autoware/share/autoware_raw_vehicle_cmd_converter/data/default/
accel_map.csv  brake_map.csv  steer_map.csv

@youtalk youtalk merged commit f9a7380 into main Sep 20, 2024
32 checks passed
@youtalk youtalk deleted the not-ignore-png-csv branch September 20, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check type:containers Docker containers, containerization of components, or container orchestration.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Missing Files in Docker Images
2 participants