-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docker): add platform tag and increase frequency of multi-arch manifest workflow #5256
Conversation
… workflow Signed-off-by: Oguz Ozturk <[email protected]>
@youtalk @mitsudome-r please review |
Here is the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please merge the latest main branch first.
Signed-off-by: Oguz Ozturk <[email protected]>
Please review again @youtalk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Add platform tag (
arm64,amd64
) and increase the frequency ofupdate-docker-manifest
workflow to every 2 hours.Because image generation happens in seperate workflows for each architecture, to achieve smooth multi-architecture support on
ghcr
we need to increase the frequency ofupdate-docker-manifest
workflow.update-docker-manifest
completes within 2-3 minutes so it would not bring overhead to overal workflows.!! Merging this PR eliminates the need of merging this PR
Tests performed
amd64-build-push -> https://github.com/autowarefoundation/autoware/actions/runs/10932018202
arm64-build-push -> https://github.com/autowarefoundation/autoware/actions/runs/10932076827
update-docker-manifest -> https://github.com/autowarefoundation/autoware/actions/runs/10937223736
Here is the
universe-planning-control
combined image after merging separate arch images:Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.