Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): add platform tag and increase frequency of multi-arch manifest workflow #5256

Merged
merged 2 commits into from
Sep 21, 2024

Conversation

oguzkaganozt
Copy link
Contributor

@oguzkaganozt oguzkaganozt commented Sep 19, 2024

Description

Add platform tag (arm64,amd64) and increase the frequency of update-docker-manifest workflow to every 2 hours.

Because image generation happens in seperate workflows for each architecture, to achieve smooth multi-architecture support on ghcr we need to increase the frequency of update-docker-manifest workflow.

update-docker-manifest completes within 2-3 minutes so it would not bring overhead to overal workflows.

!! Merging this PR eliminates the need of merging this PR

Tests performed

amd64-build-push -> https://github.com/autowarefoundation/autoware/actions/runs/10932018202
arm64-build-push -> https://github.com/autowarefoundation/autoware/actions/runs/10932076827
update-docker-manifest -> https://github.com/autowarefoundation/autoware/actions/runs/10937223736

Here is the universe-planning-control combined image after merging separate arch images:

imgimg

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@oguzkaganozt oguzkaganozt self-assigned this Sep 19, 2024
@oguzkaganozt oguzkaganozt added type:containers Docker containers, containerization of components, or container orchestration. component:openadkit Issues or Features related to Open AD Kit labels Sep 19, 2024
@oguzkaganozt oguzkaganozt added the tag:run-health-check Run health-check label Sep 19, 2024
@oguzkaganozt
Copy link
Contributor Author

@youtalk @mitsudome-r please review

@oguzkaganozt
Copy link
Contributor Author

oguzkaganozt commented Sep 19, 2024

Here is the universe-planning-control combined image after merging separate arch images @youtalk @mitsudome-r @xmfcx :

imgimg

Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge the latest main branch first.

.github/workflows/docker-build-and-push-arm64.yaml Outdated Show resolved Hide resolved
Signed-off-by: Oguz Ozturk <[email protected]>
@oguzkaganozt
Copy link
Contributor Author

Please review again @youtalk

Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oguzkaganozt oguzkaganozt merged commit d0536ca into main Sep 21, 2024
15 checks passed
@oguzkaganozt oguzkaganozt deleted the fix-docker-arm-tags branch September 21, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check type:containers Docker containers, containerization of components, or container orchestration.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants