-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docker,ci): push autoware
image on "push to main branch" and "push tag" events
#4993
Conversation
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
This reverts commit 5f3b139.
Signed-off-by: Yutaka Kondo <[email protected]>
I've submitted a |
When do we need new images?
This was to loosely handle these updates, with a twice a month schedule. ROS 2 has nightly images: https://hub.docker.com/layers/osrf/ros2/nightly/images/sha256-1f29100323ee91dbc90ed248862c408d67ceb9580757bc9c94005de0c2144fef?context=explore
It seems they generate these dockerfilesi with this create_dockerfiles.py script explained here.
If we don't check for changes made in:
I'm ok with keeping this.
This is for testing, why remove it? |
Directly related issue and PR regarding to the following being removed: on:
push:
branches:
- main |
https://github.com/marketplace/actions/changed-files This can be used to detect changes to certain files within this repository. |
autoware
image on push to main branch
and push tag
eventsautoware
image on push to main branch" and "push tag" events
autoware
image on push to main branch" and "push tag" eventsautoware
image on "push to main branch" and "push tag" events
I'm sorry but I just forgot the listing and have fixed the PR description #4993 (comment). I'm trying to modify the workflow based on your suggestion. Please wait a while. |
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
Signed-off-by: Yutaka Kondo <[email protected]>
I have modified this PR so that the build is only executed when there are changes to the corresponding files using I've checked that the @xmfcx Please review again. |
Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk -san, what do you think about nightly builds? Rest of the changes look good 👍 Thank you. |
I think we need to re-enable the artifact saving option as |
@xmfcx |
Description
Under the current GitHub Actions' workflow configuration, the
autoware
images are only pushed at the following times:openadkit-v*.*.*
tag pushedworkflow_dispatch
withregistory
option dispatchedSince 1 and 3 have nerver been executed so far, images have actually only been pushed regularly on the 1st and 15th of each month. However, there is no particular significance to the 1st and 15th of each month.
In order to advance the version control and proceed with container development and operation, it is necessary to always be able to pull the latest container images.
Therefore, this PR revises the image push timings as follows:
workflow_dispatch
dispatchedI would like to propose a revision of the naming conventions for the Docker images and tags in a discussions and a separate PR later.
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.