-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update to CUDA 12.3 #3956
Conversation
Signed-off-by: Esteve Fernandez <[email protected]>
Back to draft, I hadn't realized the TensorRT packages are in a separate Ansible script |
…e script Signed-off-by: Esteve Fernandez <[email protected]>
@xmfcx this is ready for review now. |
I will try to test it tomorrow, thank you for your efforts! |
Signed-off-by: Esteve Fernandez <[email protected]>
67d9220
to
a35c308
Compare
@xmfcx thanks for the prompt review. I've incorporated your feedback and pushed a new commit. I'm runnning this locally, though I won't be able to fully test it, just make sure that it can be built. |
It seems there is:
We might need to override the TensorRT version. I've checked that
But it doesn't contain:
Instead, it contains:
So, we might need to add:
Also we need to check where in the code it does the overriding. |
@xmfcx do we need the packages from the |
Just to reply my own question, I think we do need the packages from |
Yes, it is referenced in https://github.com/autowarefoundation/autoware/blob/main/ansible/roles/cuda/tasks/main.yaml#L6 |
Signed-off-by: Esteve Fernandez <[email protected]>
@xmfcx I'm building this branch on an ARM virtual machine, so far it seems to be using the correct version of TensorRT for ARM (8.6.2.2-1+cuda12.0) |
Spoke too soon, the |
Signed-off-by: Esteve Fernandez <[email protected]>
Signed-off-by: Esteve Fernandez <[email protected]>
@xmfcx I've built Autoware in an ARM VM and CUDA gets detected and the perception packages are built, I assume the result is correct. |
Thanks for your efforts @esteve on this PR.
and will merge when they are done. |
@xmfcx it seems that both jobs passed! 🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎊🪩🎊🪩🎊
Is it possible to downgrade to 12.2 to match https://developer.nvidia.com/embedded/jetpack? |
@kaspermeck-arm we could, this PR didn't make any changes in the code. For Jetson devices, I assume they won't install CUDA separately since it would come with the JetPack. And even looking at the changes here, as long as it is CUDA 12, they seem to be playing well with each other.
Do you think we should still change the version? |
@xmfcx We wouldn't install the driver on the Jetson platforms, but we would deploy CUDA capable containers on it. The driver is backwards compatible, i.e., you can run CUDA 12.1 on the 12.2 driver. Doing it the other way around can lead to complications. Yes, I do think we should downgrade to |
Description
This PR updates the ansible scripts CUDA to 12.3.
Fixes #3943
Related links
Tests performed
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.