Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_dummy_object_rviz_plugin): fix missing dependency #9306

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Nov 12, 2024

Description

tier4_dummy_object_rviz_plugin uses Boost, but it hasn't been declared as a dependency in package.xml

Related links

Parent Issue:

https://github.com/autowarefoundation/autoware-deb-packages/actions/runs/11663346804/job/32471666820?pr=101

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:simulation Virtual environment setups and simulations. (auto-assigned) label Nov 12, 2024
Copy link

github-actions bot commented Nov 12, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@mitsudome-r
Copy link
Member

NOTE: It's used in this line for example:

@mitsudome-r mitsudome-r self-requested a review November 12, 2024 15:14
@esteve esteve enabled auto-merge (squash) November 13, 2024 10:35
@esteve esteve added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.19%. Comparing base (1ab29fd) to head (e0261a8).
Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9306   +/-   ##
=======================================
  Coverage   29.19%   29.19%           
=======================================
  Files        1333     1333           
  Lines      102795   102795           
  Branches    39870    39870           
=======================================
  Hits        30008    30008           
  Misses      69926    69926           
  Partials     2861     2861           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 29.19% <ø> (ø) Carriedforward from 1ab29fd

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@esteve esteve self-assigned this Nov 13, 2024
@esteve
Copy link
Contributor Author

esteve commented Nov 13, 2024

@mitsudome-r could you merge this PR? It's so that the CI can build packages again. Thanks.

@mitsudome-r mitsudome-r merged commit 6a1ddbd into autowarefoundation:main Nov 13, 2024
41 of 42 checks passed
@esteve esteve deleted the fix-dumnmy-object-dep branch November 13, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:simulation Virtual environment setups and simulations. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants