Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(.github): update image tags #9286

Merged
merged 3 commits into from
Nov 12, 2024
Merged

ci(.github): update image tags #9286

merged 3 commits into from
Nov 12, 2024

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Nov 11, 2024 •
edited
Loading

Description

This PR is a revision of #9096, changing it to use the development container images instead of the runtime container images.

CUDA CI might not work as expected.

In build-and-test CUDA workflow I see packages are not being built properly due to missing libraries e.g. here. This is because previous images had an issue, which is already fixed. This fix applies for already changed image tags. Currently CI operates on deprecated tags and consists of quite old update:

ghcr.io/autowarefoundation/autoware                                                    latest-autoware-universe-cuda   f7ff8a8144d2   5 weeks ago    10.4GB

This PR update tags.

Related links

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@youtalk
update image tags
75965be 
Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk youtalk self-assigned this Nov 11, 2024
@github-actions github-actions bot added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Nov 11, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 11, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@youtalk youtalk added tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) and removed type:ci Continuous Integration (CI) processes and testing. (auto-assigned) labels Nov 11, 2024
@youtalk
wip
58de6b1 
Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk
Revert "wip"
598d951 
This reverts commit 58de6b1.
@youtalk youtalk marked this pull request as ready for review November 11, 2024 23:25
amadeuszsz
amadeuszsz approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@amadeuszsz amadeuszsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youtalk youtalk merged commit e8a4d87 into autowarefoundation:main Nov 12, 2024
26 checks passed
@youtalk youtalk mentioned this pull request Nov 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amadeuszsz amadeuszsz amadeuszsz approved these changes

@mitsudome-r mitsudome-r Awaiting requested review from mitsudome-r

@xmfcx xmfcx Awaiting requested review from xmfcx

Assignees

@youtalk youtalk

Labels
tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youtalk @amadeuszsz