Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(goal_planner): remove reference_goal_pose getter/setter #9270

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Nov 8, 2024

Description

referance_goal_pose in GoalSearcher does not need to be saved as a state. So pass then in the caller side using GoalSearcher.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 8, 2024
Copy link

github-actions bot commented Nov 8, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@soblin soblin force-pushed the refactor/goal-candidate branch 3 times, most recently from 647dc0b to 80de1b5 Compare November 8, 2024 10:06
@soblin soblin marked this pull request as ready for review November 8, 2024 10:23
@soblin soblin added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 29.22%. Comparing base (4f29939) to head (1bd10db).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
...ior_path_goal_planner_module/src/goal_searcher.cpp 0.00% 14 Missing ⚠️
...th_goal_planner_module/src/goal_planner_module.cpp 0.00% 6 Missing ⚠️
...or_path_goal_planner_module/goal_searcher_base.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9270      +/-   ##
==========================================
- Coverage   29.23%   29.22%   -0.02%     
==========================================
  Files        1335     1338       +3     
  Lines      102959   103018      +59     
  Branches    39947    39961      +14     
==========================================
  Hits        30102    30102              
- Misses      69898    70034     +136     
+ Partials     2959     2882      -77     
Flag Coverage Δ *Carryforward flag
differential 0.52% <0.00%> (?)
total 29.24% <ø> (+<0.01%) ⬆️ Carriedforward from 6d38b5f

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +439 to +440
auto goal_searcher = std::make_shared<GoalSearcher>(parameters, vehicle_footprint);

Copy link
Contributor

@kosuke55 kosuke55 Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
auto goal_searcher = std::make_shared<GoalSearcher>(parameters, vehicle_footprint);
const auto goal_searcher = std::make_shared<GoalSearcher>(parameters, vehicle_footprint);

?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is now only used within planFreespacePath(), it may be ok to generate it within that function.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(update() does not depend on search(), and there is no problem if we pass goal candidates. It seems like it would be ok to make update() a static method.)

@soblin soblin merged commit c5f94db into autowarefoundation:main Nov 13, 2024
35 of 36 checks passed
@soblin soblin deleted the refactor/goal-candidate branch November 13, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants