-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(goal_planner): remove reference_goal_pose getter/setter #9270
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
647dc0b
to
80de1b5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9270 +/- ##
==========================================
- Coverage 29.23% 29.22% -0.02%
==========================================
Files 1335 1338 +3
Lines 102959 103018 +59
Branches 39947 39961 +14
==========================================
Hits 30102 30102
- Misses 69898 70034 +136
+ Partials 2959 2882 -77
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4ba1dec
to
eeb42e6
Compare
Signed-off-by: Mamoru Sobue <[email protected]>
eeb42e6
to
1bd10db
Compare
auto goal_searcher = std::make_shared<GoalSearcher>(parameters, vehicle_footprint); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
auto goal_searcher = std::make_shared<GoalSearcher>(parameters, vehicle_footprint); | |
const auto goal_searcher = std::make_shared<GoalSearcher>(parameters, vehicle_footprint); | |
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it is now only used within planFreespacePath(), it may be ok to generate it within that function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(update() does not depend on search(), and there is no problem if we pass goal candidates. It seems like it would be ok to make update() a static method.)
Description
referance_goal_pose
in GoalSearcher does not need to be saved as a state. So pass then in the caller side using GoalSearcher.Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.