Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(fake_test_node): prefix package and namespace with autoware #9249

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(fake_test_node): prefix package and namespace with autoware #9249

wants to merge 1 commit into from
+34 −51

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Nov 6, 2024 •
edited
Loading

Description

prefix package and namespace with autoware

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Nov 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@esteve esteve added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 6, 2024
@esteve esteve self-assigned this Nov 6, 2024
@esteve esteve mentioned this pull request Nov 6, 2024
Open
46 tasks
@esteve esteve marked this pull request as ready for review November 6, 2024 13:01
@esteve esteve enabled auto-merge (squash) November 6, 2024 13:01
@esteve esteve force-pushed the prefix-fake_test_node branch 2 times, most recently from f9189f0 to 50655b5 Compare November 13, 2024 10:46
@esteve
Copy link
Contributor Author

esteve commented Nov 13, 2024

@maxime-clem thanks for the review.

@xmfcx can you merge this? Thanks.

@xmfcx xmfcx disabled auto-merge November 13, 2024 11:53
@xmfcx
Copy link
Contributor

xmfcx commented Nov 13, 2024

https://github.com/autowarefoundation/autoware.universe/actions/runs/11815670194/job/32917329699?pr=9249#step:5:13854

/__w/autoware.universe/autoware.universe/common/autoware_fake_test_node/test/test_fake_test_node.cpp:33:35: error: ‘tools’ in namespace ‘autoware’ does not name a type
   33 | using FakeNodeFixture = autoware::tools::testing::FakeTestNode;
      |                                   ^~~~~

CI has failed.

@esteve
Copy link
Contributor Author

esteve commented Nov 13, 2024

@xmfcx fixed in 6daea4b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxime-clem maxime-clem maxime-clem approved these changes

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168 takayuki5168 is a code owner

@kosuke55 kosuke55 Awaiting requested review from kosuke55 kosuke55 is a code owner

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe is a code owner

@satoshi-ota satoshi-ota Awaiting requested review from satoshi-ota satoshi-ota is a code owner

@shmpwk shmpwk Awaiting requested review from shmpwk shmpwk is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@esteve esteve

Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@esteve @xmfcx @maxime-clem