fix(autoware_mpc_lateral_controller): fix bugprone-misplaced-widening-cast

[kobayu858]

Description

This is a fix based on clang-tidy bugprone-misplaced-widening-cast error.

/home/emb4/autoware/autoware/src/universe/autoware.universe/control/autoware_mpc_lateral_controller/src/lowpass_filter.cpp:128:16: error: either cast from 'int' to 'size_t' (aka 'unsigned long') is ineffective, or there is loss of precision before the conversion [bugprone-misplaced-widening-cast,-warnings-as-errors]
      tmp += u[static_cast<size_t>(i + j)];
               ^

Related links

Parent Issue:

• Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

[kobayu858]

Other errors also exist, but they are not corrected at this time because of their low severity.

[github-actions]

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

• You've checked our contribution guidelines.
• Your PR follows our pull request guidelines.
• All required CI checks pass before marking the PR ready for review.

[veqcc]

@kobayu858
Your change seems to be incorrect. Please check again.

[codecov]

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.92%. Comparing base (458f3d9) to head (53c0525).
Report is 66 commits behind head on main.

Files with missing lines	Patch %	Lines
...ware_mpc_lateral_controller/src/lowpass_filter.cpp	75.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9224      +/-   ##
==========================================
- Coverage   28.92%   28.92%   -0.01%     
==========================================
  Files        1324     1324              
  Lines      102572   102584      +12     
  Branches    39795    39796       +1     
==========================================
  Hits        29673    29673              
- Misses      70027    70037      +10     
- Partials     2872     2874       +2     

Flag	Coverage Δ		*Carryforward flag
differential	33.43% <75.00%> (?)
total	28.92% <ø> (-0.01%)	⬇️	Carriedforward from 1d1b72b

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kobayu858]

@veqcc
I forgot that it is a negative value. Thank you for pointing that out.

[kobayu858]

The index is now calculated first to make sure it does not exceed the range before casting.

[kobayu858]

@TakaHoribe @takayuki5168
Please confirm the PR. Thank you very much.