Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(autoware_point_types): prefix namespace with autoware::point_types #9169

Merged
merged 3 commits into from
Oct 30, 2024
Merged

refactor(autoware_point_types): prefix namespace with autoware::point_types #9169

merged 3 commits into from
Oct 30, 2024

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Oct 28, 2024

Description

prefix namespace with autoware

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) tag:require-cuda-build-and-test labels Oct 28, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 28, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@esteve esteve mentioned this pull request Oct 28, 2024
Open
46 tasks
@esteve esteve added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 28, 2024
@esteve esteve marked this pull request as ready for review October 28, 2024 15:01
@esteve esteve self-assigned this Oct 28, 2024
knzo25
knzo25 approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@knzo25 knzo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@YamatoAndo
Copy link
Contributor

Once the maintainer of autoware_point_types approves, I'll also approve the localization module.

@knzo25
Copy link
Contributor

knzo25 commented Oct 29, 2024

@drwnz @mojomex 🙏

drwnz
drwnz approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@esteve esteve enabled auto-merge (squash) October 30, 2024 10:45
@esteve
Copy link
Contributor Author

esteve commented Oct 30, 2024

@knzo25 @YamatoAndo @drwnz thanks for your reviews.

@xmfcx @mitsudome-r could you merge this PR? @drwnz is one of the maintainers and he has approved this PR.

@xmfcx xmfcx force-pushed the prefix-autoware_point_types branch from ac43f5c to 3beecf9 Compare October 30, 2024 11:48
@codecov Codecov
Copy link

codecov bot commented Oct 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 28.76%. Comparing base (dfe7108) to head (3beecf9).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ar_marker_localizer/src/lidar_marker_localizer.cpp 0.00% 9 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9169   +/-   ##
=======================================
  Coverage   28.75%   28.76%           
=======================================
  Files        1314     1316    +2     
  Lines      101744   101797   +53     
  Branches    39596    39610   +14     
=======================================
+ Hits        29258    29283   +25     
- Misses      69675    69703   +28     
  Partials     2811     2811
Flag Coverage Δ *Carryforward flag
differential 20.01% <0.00%> (?)
total 28.75% <ø> (+<0.01%) ⬆️ Carriedforward from dfe7108

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xmfcx xmfcx disabled auto-merge October 30, 2024 12:06
@xmfcx xmfcx merged commit 94b9ad0 into autowarefoundation:main Oct 30, 2024
31 of 32 checks passed
@esteve esteve deleted the prefix-autoware_point_types branch October 30, 2024 12:32
@esteve
Copy link
Contributor Author

esteve commented Oct 30, 2024

@xmfcx thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drwnz drwnz drwnz approved these changes

@YamatoAndo YamatoAndo YamatoAndo approved these changes

@knzo25 knzo25 knzo25 approved these changes

@amc-nu amc-nu Awaiting requested review from amc-nu amc-nu is a code owner

@badai-nguyen badai-nguyen Awaiting requested review from badai-nguyen badai-nguyen is a code owner

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara kyoichi-sugahara is a code owner

@meliketanrikulu meliketanrikulu Awaiting requested review from meliketanrikulu meliketanrikulu is a code owner

@miursh miursh Awaiting requested review from miursh miursh is a code owner

@vividf vividf Awaiting requested review from vividf vividf is a code owner

@YoshiRi YoshiRi Awaiting requested review from YoshiRi YoshiRi is a code owner

@yukkysaito yukkysaito Awaiting requested review from yukkysaito yukkysaito is a code owner

@amadeuszsz amadeuszsz Awaiting requested review from amadeuszsz amadeuszsz is a code owner

@scepter914 scepter914 Awaiting requested review from scepter914 scepter914 is a code owner

@kminoda kminoda Awaiting requested review from kminoda kminoda is a code owner

@ktro2828 ktro2828 Awaiting requested review from ktro2828 ktro2828 is a code owner

@tzhong518 tzhong518 Awaiting requested review from tzhong518 tzhong518 is a code owner

@SakodaShintaro SakodaShintaro Awaiting requested review from SakodaShintaro SakodaShintaro is a code owner

@mojomex mojomex Awaiting requested review from mojomex mojomex is a code owner

Assignees

@esteve esteve

Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) tag:require-cuda-build-and-test tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Sensing & Perception Working Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@esteve @YamatoAndo @knzo25 @drwnz @xmfcx