feat(autonomous_emergency_braking): calculate the object's velocity in the search area #8591
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
Change in average Code Health of affected files: -0.08 (7.44 -> 7.36)
- Declining Code Health: 2 findings(s) 🚩
- Improving Code Health: 3 findings(s) ✅
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method node.cpp: AEB::checkCollision
- Complex Method node.cpp: AEB::getClosestObjectsOnPath
✅ Improving Code Health:
- Bumpy Road Ahead node.cpp: AEB::getClosestObjectsOnPath
- Excess Number of Function Arguments node.cpp: AEB::getClosestObjectsOnPath
- Complex Conditional node.cpp: AEB::getClosestObjectsOnPath
Annotations
Check warning on line 589 in control/autoware_autonomous_emergency_braking/src/node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
AEB::checkCollision increases in cyclomatic complexity from 29 to 34, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 921 in control/autoware_autonomous_emergency_braking/src/node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
AEB::getClosestObjectsOnPath increases in cyclomatic complexity from 10 to 11, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 921 in control/autoware_autonomous_emergency_braking/src/node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Bumpy Road Ahead
AEB::getClosestObjectsOnPath is no longer above the threshold for logical blocks with deeply nested code. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check notice on line 589 in control/autoware_autonomous_emergency_braking/src/node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ New issue: Bumpy Road Ahead
AEB::checkCollision has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check notice on line 1 in control/autoware_autonomous_emergency_braking/src/node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 5.43 to 5.83, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Check notice on line 921 in control/autoware_autonomous_emergency_braking/src/node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Excess Number of Function Arguments
AEB::getClosestObjectsOnPath is no longer above the threshold for number of arguments. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
Check notice on line 878 in control/autoware_autonomous_emergency_braking/src/node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Conditional
AEB::getClosestObjectsOnPath no longer has a complex conditional