docs: add apt update/upgrade to workspace install/update instructions #615
+32
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max SCHMELLER <[email protected]>
mojomex
force-pushed
the
feat/mention-apt-upgrade
branch
from
35abfe9
to
b67604f
Compare
mojomex
added
the
tag:deploy-docs
Merged
4 tasks
|
This workflow works on I will just go ahead and merge the other PR. |
xmfcx
force-pushed
the
feat/mention-apt-upgrade
branch
from
9a0cc4c
to
7db8561
Compare
|
Documentation URL: https://autowarefoundation.github.io/autoware-documentation/pr-615/ |
xmfcx
reviewed
Sep 19, 2024
xmfcx
reviewed
Sep 19, 2024
Co-authored-by: M. Fatih Cırıt <[email protected]> Signed-off-by: Max SCHMELLER <[email protected]>
mojomex
force-pushed
the
feat/mention-apt-upgrade
branch
from
faef811
to
6ff3cf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added missing instructions to the following guides:
Specifically,
sudo apt update && sudo apt upgradewere missing:rosdep updateandrosdep installwill not upgrade previously installedros-$ROS_DISTRO-*packages (even when Autoware is expected to be built with newer versions), which often results in unexpected Autoware build failures.From my experience in the last two weeks, following the instructions perfectly on a clean Autoware repo succeeded one out of five times mainly due to this issue.
I also added comments that for moved/removed dependencies in the
reposfiles,vcstoolwill not sync correctly and result in duplicate or wrongly remaining packages, in which case thesrcdirectory has to be deleted and re-pulled.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The Reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.