Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add review tips #46

Merged
merged 2 commits into from
Mar 11, 2022
Merged

docs: add review tips #46

merged 2 commits into from
Mar 11, 2022

Conversation

kenji-miyake
Copy link
Contributor

Related: #6

@kenji-miyake kenji-miyake added the type:documentation Creating or refining documentation. label Mar 6, 2022
@github-actions
Copy link

github-actions bot commented Mar 6, 2022

Documentation URL: https://autowarefoundation.github.io/autoware-documentation/pr-46/
Modified URLs:

Base automatically changed from add-pull-request-guidelines to add-support-guidelines March 9, 2022 09:24
Kenji Miyake added 2 commits March 9, 2022 18:26
docs: add review tips
c27a37c 
Signed-off-by: Kenji Miyake <[email protected]>
update .pages
641e103 
Signed-off-by: Kenji Miyake <[email protected]>
isamu-takagi
isamu-takagi previously approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I didn't know 'i' and 'A' key shortcuts. This is very useful.

@kenji-miyake kenji-miyake changed the base branch from add-support-guidelines to main March 9, 2022 09:42
@kenji-miyake kenji-miyake dismissed isamu-takagi’s stale review March 9, 2022 09:42

The base branch was changed.

xmfcx
xmfcx approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kenji-miyake thanks for all the work. Let's merge this and we can iterate over it as we proceed.

@kenji-miyake kenji-miyake merged commit 34b4cc5 into main Mar 11, 2022
@kenji-miyake kenji-miyake deleted the add-review-tips branch March 11, 2022 10:38
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Mar 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmfcx xmfcx xmfcx approved these changes

@isamu-takagi isamu-takagi isamu-takagi left review comments

@mitsudome-r mitsudome-r Awaiting requested review from mitsudome-r

Assignees
No one assigned
Labels
type:documentation Creating or refining documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenji-miyake @xmfcx @isamu-takagi