13 TeV cpp, pyroot, and Rdataframe notebooks

[marianaiv]

I updated the notebooks for 13 TeV in the folders cpp, pyroot and Rdataframe.

I added documentation to the notebooks that made sense to me. In this document I listed the notebooks that I think shouldn't be linked in the website and should probably be deleted (which are the ones I didn't added documentation to). I can delete them in this same PR if we agree about it.

Aside from the added documentation, I changed some file names and folder names so that the repository makes more sense. I'll update the links for everything in the website once we decide to merge.

[marianaiv]

@Soap2G since I changed the name of some files/folders, how can I fix the automatic checks?

[Soap2G]

Hi @marianaiv, thanks for the changes, looks very good to me!

Let me just comment on a couple of points:

1. Pipeline failing on 3 jobs: this is actually a bug, that is given by the fact that in the pipeline we make git detect all the modified files, and this includes the deleted ones. Therefore, the 3 jobs failing are failing because the script cannot cd into a folder that doesn't exist anymore. We can fix that in the workflow file to force the command to return only the added or modified files:

DIFF=$(git diff --name-status origin/master...HEAD --diff-filter=dr | grep ipynb || true)

where --diff-filter=dr excludes deleted or renamed files. Not 100% sure it works, needs to be tested.

2. the general papermill script (the one that runs on all the notebooks) is built to have hardcoded folders. In the case of python, the relevant line is here. We should change it to account for the pyroot folder, rather than python.

3. Just for the sake of completeness, I didn't see any conflicts wrt PR Updating broken notebooks #57, so I believe we are good. But an additional eye doesn't hurt :)

[marianaiv]

Hi @Soap2G,

Thanks for the insight!

On the notebooks: I didn't change the notebooks in the uproot folder. I'm waiting for that PR to be merge to start checking those 🙂