Consolidate UnusableDependencies into a generic Unavailable incompatibility
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
added a commit
to astral-sh/uv
that referenced
this pull request
Jan 25, 2024
…patibility (#1088) Requires astral-sh/pubgrub#20 In short, `UnusableDependencies` can be generalized into `Unavailable` which encompasses incompatibilities where a package range which is unusable for some inherent reason as well as when its dependencies are unusable. We can eventually use this to track more incompatibilities in the solver. I made the reason string required because I can't see a case where we should leave it out. Additionally, this improves the display of conflicts in the root requirements.
charliermarsh
approved these changes
Jan 25, 2024
|
This fork seams to be working well. My qualms about reusability are not slowing you down, and we are still getting things done together on the main repo! Let's hope for continued win-wins! |
konstin
pushed a commit
that referenced
this pull request
Mar 6, 2024
…patibility (#20) * Consolidate `UnusableDependencies` into a generic `Unavailable` incompatibility * Docs
konstin
pushed a commit
that referenced
this pull request
Mar 12, 2024
…patibility (#20) * Consolidate `UnusableDependencies` into a generic `Unavailable` incompatibility * Docs
konstin
pushed a commit
that referenced
this pull request
Mar 12, 2024
…patibility (#20) * Consolidate `UnusableDependencies` into a generic `Unavailable` incompatibility * Docs
konstin
pushed a commit
that referenced
this pull request
Mar 13, 2024
…patibility (#20) * Consolidate `UnusableDependencies` into a generic `Unavailable` incompatibility * Docs
konstin
pushed a commit
that referenced
this pull request
Mar 22, 2024
…patibility (#20) * Consolidate `UnusableDependencies` into a generic `Unavailable` incompatibility * Docs
konstin
pushed a commit
that referenced
this pull request
May 2, 2024
…patibility (#20) * Consolidate `UnusableDependencies` into a generic `Unavailable` incompatibility * Docs
konstin
pushed a commit
that referenced
this pull request
May 7, 2024
…patibility (#20) * Consolidate `UnusableDependencies` into a generic `Unavailable` incompatibility * Docs
konstin
pushed a commit
that referenced
this pull request
May 8, 2024
…patibility (#20) * Consolidate `UnusableDependencies` into a generic `Unavailable` incompatibility * Docs
konstin
pushed a commit
that referenced
this pull request
May 21, 2024
…patibility (#20) * Consolidate `UnusableDependencies` into a generic `Unavailable` incompatibility * Docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up to the discussion in pubgrub-rs#153 consolidating our unusable dependencies type with general unavailability. I've decided not to wait until we introduce a generic "metadata" type which is much more work.