Consolidate UnusableDependencies into a generic Unavailable incompatibility
#1088
+54
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
force-pushed
the
zb/unavailable
branch
from
af04408
to
f38c7b8
Compare
zanieb
added
internal
|
Oops, @charliermarsh / @konstin can one one of you review the PubGrub pull request too and I'll merge and follow up with an update to the pin here? |
|
Yeah |
zanieb
added a commit
that referenced
this pull request
Jan 25, 2024
Just fixing the wrong merge order from #1088
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires astral-sh/pubgrub#20
In short,
UnusableDependenciescan be generalized intoUnavailablewhich encompasses incompatibilities where a package range which is unusable for some inherent reason as well as when its dependencies are unusable. We can eventually use this to track more incompatibilities in the solver. I made the reason string required because I can't see a case where we should leave it out.Additionally, this improves the display of conflicts in the root requirements.