fix: do not start obsolete daemon watcher process

Before arduino/arduino-cli#488, IDE2 required a way to stop the daemon process if the parent (backend) process crashed. However, this mechanism is no longer necessary as the CLI daemon process is not actually a true daemon process. Signed-off-by: Akos Kitta <[email protected]>
arduino · Aug 20, 2023 · 57fa18b · 57fa18b
1 parent 2aae9e0
commit 57fa18b
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 39 deletions.
diff --git a/arduino-ide-extension/src/node/arduino-daemon-impl.ts b/arduino-ide-extension/src/node/arduino-daemon-impl.ts
@@ -10,7 +10,6 @@ import {
 } from '@theia/core/lib/common/disposable';
 import { Event, Emitter } from '@theia/core/lib/common/event';
 import { deepClone } from '@theia/core/lib/common/objects';
-import { environment } from '@theia/application-package/lib/environment';
 import { EnvVariablesServer } from '@theia/core/lib/common/env-variables';
 import { BackendApplicationContribution } from '@theia/core/lib/node/backend-application';
 import { ArduinoDaemon, NotificationServiceServer } from '../common/protocol';
@@ -71,22 +70,6 @@ export class ArduinoDaemonImpl
       const cliPath = this.getExecPath();
       this.onData(`Starting daemon from ${cliPath}...`);
       const { daemon, port } = await this.spawnDaemonProcess();
-      // Watchdog process for terminating the daemon process when the backend app terminates.
-      spawn(
-        process.execPath,
-        [
-          join(__dirname, 'daemon-watcher.js'),
-          String(process.pid),
-          String(daemon.pid),
-        ],
-        {
-          env: environment.electron.runAsNodeEnv(),
-          detached: true,
-          stdio: 'ignore',
-          windowsHide: true,
-        }
-      ).unref();
-
       this.toDispose.pushAll([
         Disposable.create(() => {
           if (daemon.pid) {

diff --git a/arduino-ide-extension/src/node/daemon-watcher.ts b/arduino-ide-extension/src/node/daemon-watcher.ts