Skip to content

Commit

Permalink
fix: execute the Arduino CLI without a shell
Browse files Browse the repository at this point in the history
Closes #2112
Ref: #2067

Signed-off-by: Akos Kitta <[email protected]>
  • Loading branch information
Akos Kitta authored and kittaakos committed Aug 20, 2023
1 parent 9a99957 commit 2aae9e0
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions arduino-ide-extension/src/node/arduino-daemon-impl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -173,10 +173,9 @@ export class ArduinoDaemonImpl
const cliPath = this.getExecPath();
const ready = new Deferred<{ daemon: ChildProcess; port: string }>();
const options = {
shell: true,
env: { ...deepClone(process.env), NO_COLOR: String(true) },
};
const daemon = spawn(`"${cliPath}"`, args, options);
const daemon = spawn(cliPath, args, options);

// If the process exists right after the daemon gRPC server has started (due to an invalid port, unknown address, TCP port in use, etc.)
// we have no idea about the root cause unless we sniff into the first data package and dispatch the logic on that. Note, we get a exit code 1.
Expand Down

0 comments on commit 2aae9e0

Please sign in to comment.