-
-
Notifications
You must be signed in to change notification settings - Fork 390
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: incorrect certificate flashing command string (#2181)
Use a `string` array of command flags instead of the concatenated final `string` command. Ref: #2067 Closes #2179 Signed-off-by: Akos Kitta <[email protected]>
- Loading branch information
Showing
3 changed files
with
27 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 9 additions & 4 deletions
13
arduino-ide-extension/src/common/protocol/arduino-firmware-uploader.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,24 @@ | ||
import { Port } from "./boards-service"; | ||
import type { Port } from './boards-service'; | ||
|
||
export const ArduinoFirmwareUploaderPath = | ||
'/services/arduino-firmware-uploader'; | ||
export const ArduinoFirmwareUploader = Symbol('ArduinoFirmwareUploader'); | ||
export type FirmwareInfo = { | ||
export interface FirmwareInfo { | ||
board_name: string; | ||
board_fqbn: string; | ||
module: string; | ||
firmware_version: string; | ||
Latest: boolean; | ||
}; | ||
} | ||
export interface UploadCertificateParams { | ||
readonly fqbn: string; | ||
readonly address: string; | ||
readonly urls: readonly string[]; | ||
} | ||
export interface ArduinoFirmwareUploader { | ||
list(fqbn?: string): Promise<FirmwareInfo[]>; | ||
flash(firmware: FirmwareInfo, port: Port): Promise<string>; | ||
uploadCertificates(command: string): Promise<any>; | ||
uploadCertificates(params: UploadCertificateParams): Promise<unknown>; | ||
updatableBoards(): Promise<string[]>; | ||
availableFirmwares(fqbn: string): Promise<FirmwareInfo[]>; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters