Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gRPC function call to avoid accessing arduino/cores package directly #2292

Conversation

MatteoPologruto
Copy link
Contributor

@MatteoPologruto MatteoPologruto commented Sep 4, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

No changes, the code is reorganized to avoid accessing arduino/cores package directly.

Does this PR introduce a breaking change, and is titled accordingly?

No

Other information

Related to #1948

@MatteoPologruto MatteoPologruto added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Sep 4, 2023
@MatteoPologruto MatteoPologruto self-assigned this Sep 4, 2023
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04% 🎉

Comparison is base (3f9373a) 63.40% compared to head (e244d17) 63.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2292      +/-   ##
==========================================
+ Coverage   63.40%   63.45%   +0.04%     
==========================================
  Files         219      219              
  Lines       19536    19538       +2     
==========================================
+ Hits        12386    12397      +11     
+ Misses       6069     6052      -17     
- Partials     1081     1089       +8     
Flag Coverage Δ
unit 63.45% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
internal/cli/arguments/completion.go 87.83% <100.00%> (+0.16%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MatteoPologruto MatteoPologruto merged commit 9dede8a into arduino:master Sep 6, 2023
89 checks passed
@MatteoPologruto MatteoPologruto deleted the remove-access-to-arduino-cores branch September 6, 2023 09:15
@cmaglie cmaglie changed the title [skip-changelog] Use gRPC function call to avoid accessing arduino/cores package directly Use gRPC function call to avoid accessing arduino/cores package directly Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants