Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip-changelog] Remove most of the direct accesses to arduino package #2296

Conversation

MatteoPologruto
Copy link
Contributor

@MatteoPologruto MatteoPologruto commented Sep 6, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

No changes. The CLI code now relies more on the gRPC interface.

Does this PR introduce a breaking change, and is titled accordingly?

No

Other information

Follow up to: #2292 and #2297

@MatteoPologruto MatteoPologruto added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Sep 6, 2023
@MatteoPologruto MatteoPologruto self-assigned this Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage: 61.29% and project coverage change: -0.04% ⚠️

Comparison is base (28fc9d6) 63.07% compared to head (11326b5) 63.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2296      +/-   ##
==========================================
- Coverage   63.07%   63.04%   -0.04%     
==========================================
  Files         200      201       +1     
  Lines       19265    19268       +3     
==========================================
- Hits        12152    12147       -5     
- Misses       6063     6067       +4     
- Partials     1050     1054       +4     
Flag Coverage Δ
unit 63.04% <61.29%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
internal/cli/upload/upload.go 58.87% <0.00%> (-1.93%) ⬇️
internal/cli/compile/compile.go 73.17% <62.50%> (-0.92%) ⬇️
commands/sketch/warn_deprecated.go 100.00% <100.00%> (ø)
internal/cli/arguments/sketch.go 78.57% <100.00%> (-6.43%) ⬇️
internal/cli/sketch/archive.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

internal/cli/compile/compile.go Outdated Show resolved Hide resolved
@MatteoPologruto MatteoPologruto force-pushed the move-warn-deprecated-to-commands branch 2 times, most recently from 11b4de8 to 23f8603 Compare September 13, 2023 16:11
Copy link
Member

@cmaglie cmaglie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After applying the suggestions, it's mergeable for me 👍🏼

internal/cli/compile/compile.go Outdated Show resolved Hide resolved
internal/cli/upload/upload.go Outdated Show resolved Hide resolved
@MatteoPologruto MatteoPologruto merged commit 8043231 into arduino:master Sep 20, 2023
93 checks passed
@MatteoPologruto MatteoPologruto deleted the move-warn-deprecated-to-commands branch September 20, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli code refactoring: argument parsing/handling should not access the arduino package directly
2 participants