-
-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[skip-changelog] Remove most of the direct accesses to arduino
package
#2296
[skip-changelog] Remove most of the direct accesses to arduino
package
#2296
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2296 +/- ##
==========================================
- Coverage 63.07% 63.04% -0.04%
==========================================
Files 200 201 +1
Lines 19265 19268 +3
==========================================
- Hits 12152 12147 -5
- Misses 6063 6067 +4
- Partials 1050 1054 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
a2fc690
to
622714f
Compare
11b4de8
to
23f8603
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After applying the suggestions, it's mergeable for me 👍🏼
ea4c772
to
11326b5
Compare
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)configuration.schema.json
updated if new parameters are added.What kind of change does this PR introduce?
No changes. The CLI code now relies more on the gRPC interface.
Does this PR introduce a breaking change, and is titled accordingly?
No
Other information
Follow up to: #2292 and #2297