prevent multiple instances of TcpListener causing Socket Exception #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Unity version 2020.3.16f1, enter->leave->enter play mode will produce a Socket Exception in the console. It seems there's a zombie instance of TcpListener in a thread still listening on 3722 while Arcadia tries to start up nrepl again. Restarting Unity seems to be the only workaround when this happens.
Maintaining a single instance of
listeneras in this change is resilient to many play/stop/play cycles. I don't know enough about Arcadia's architecture or threading in .NET to determine if this would cause other problems 😄 but so far it's working for me.