fix(explore): column data type tooltip format #30588
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor visual tweak to add a column and a space inside the Explore -> LeftPanelDatasetView -> Column datatype tooltip
rusackas
reviewed
Oct 15, 2024
| @@ -55,8 +55,7 @@ const TooltipSection = ({ | |||
| text: ReactNode; | |||
| }) => ( | |||
| <TooltipSectionWrapper> | |||
| <TooltipSectionLabel>{label}</TooltipSectionLabel> | |||
| <span>{text}</span> | |||
| <TooltipSectionLabel>{label}</TooltipSectionLabel>: <span>{text}</span> | |||
There was a problem hiding this comment.
might be a legit use case for a
There was a problem hiding this comment.
Also not sure the span has any real purpose here. ¯\_(ツ)_/¯
There was a problem hiding this comment.
I had a {' '} and I think prettier changed it to what is now there. Generally I prefer the {' '} to , and if prettier is configured to do what it did, let's roll with it. About the span, I think it's referenced in the CSS so that it's not bolded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor visual tweak to add a column and a space inside the Explore -> LeftPanelDatasetView -> Column datatype tooltip.
Adding a colon and a space, and showing the data type as uppercase as it's pretty standard to expose it in that way elsewhere in Superset and as a general convention
before
after