Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(explore): column data type tooltip format #30588

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(explore): column data type tooltip format #30588

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions superset-frontend/packages/superset-ui-chart-controls/src/components/labelUtils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ const TooltipSection = ({
text: ReactNode;
}) => (
<TooltipSectionWrapper>
<TooltipSectionLabel>{label}</TooltipSectionLabel>
<span>{text}</span>
<TooltipSectionLabel>{label}</TooltipSectionLabel>: <span>{text}</span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be a legit use case for a &nbsp;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also not sure the span has any real purpose here. ¯\_(ツ)_/¯

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a {' '} and I think prettier changed it to what is now there. Generally I prefer the {' '} to &nbsp;, and if prettier is configured to do what it did, let's roll with it. About the span, I think it's referenced in the CSS so that it's not bolded.

</TooltipSectionWrapper>
);

Expand All @@ -71,12 +70,7 @@ export const getColumnTypeTooltipNode = (column: ColumnMeta): ReactNode => {
return null;
}

return (
<TooltipSection
label={t('Column datatype')}
text={column.type.toLowerCase()}
/>
);
return <TooltipSection label={t('Column type')} text={column.type} />;
};

export const getColumnTooltipNode = (
Expand Down
Loading