Adjust parameters to GoDaddy get_zone method #1967
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other drivers take the ID, not the domain name. This puts the GoDaddy driver in-line with how other drivers work.
|
@Circuitsoft Thanks for the contribution. Since this is a breaking change, can you please add an entry to Thanks. |
|
@Circuitsoft It appears tests are also failing. Can you please also look into this when you get a chance? Thanks |
Kami
reviewed
Dec 3, 2023
| :type zone_id: ``str`` | ||
|
|
||
| :rtype: :class:`Zone` | ||
| """ | ||
| result = self.connection.request("/v1/domains/%s/" % zone_id).object | ||
| domain, = [x.domain for x in self.list_zones() if x.id == zone_id] |
There was a problem hiding this comment.
This will throw in case no matching items are found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other drivers take the ID, not the domain name. This puts the GoDaddy driver in-line with how other drivers work.
Changes Title (replace this with a logical title for your changes)
Description
Saltstack has been throwing errors when working with GoDaddy dns entries because the driver takes different parameters than other drivers it was designed around. This fixes the interface to put it more in-line with other drivers.
Status
done, ready for review
Checklist (tick everything that applies)