Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust parameters to GoDaddy get_zone method #1967

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

Adjust parameters to GoDaddy get_zone method #1967

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e89c123
Adjust parameters to GoDaddy get_zone method
Circuitsoft Oct 24, 2023
2abb7ec
Merge branch 'trunk' into fix_godaddy_dns
Kami Oct 28, 2023
4bff645
Merge branch 'trunk' into fix_godaddy_dns
Kami Dec 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions libcloud/dns/drivers/godaddy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,12 +288,13 @@ def get_zone(self, zone_id):
"""
Get a zone (by domain)

:param zone_id: The domain, not the ID
:param zone_id: The domain ID
:type zone_id: ``str``

:rtype: :class:`Zone`
"""
result = self.connection.request("/v1/domains/%s/" % zone_id).object
domain, = [x.domain for x in self.list_zones() if x.id == zone_id]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will throw in case no matching items are found.

result = self.connection.request("/v1/domains/%s/" % domain).object
zone = self._to_zone(result)
return zone

Expand Down
Loading