Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VL] Malformed CI job name #6956

Merged
merged 3 commits into from
Aug 21, 2024
Merged

[VL] Malformed CI job name #6956

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
53db9db
fixup
zhztheplayer Aug 21, 2024
13b118d
Revert "fixup"
zhztheplayer Aug 21, 2024
0f4ac6a
fixup
zhztheplayer Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/velox_docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,7 @@ jobs:
GLUTEN_IT_JVM_ARGS=-Xmx5G sbin/gluten-it.sh queries-compare \
--local --preset=velox-with-celeborn --benchmark-type=ds --error-on-memleak --off-heap-size=10g -s=1.0 --threads=8 --iterations=1

run-CPP-test-UDF-test:
run-cpp-test-udf-test:
runs-on: ubuntu-20.04
container: ghcr.io/facebookincubator/velox-dev:centos8
steps:
Expand All @@ -605,6 +605,9 @@ jobs:
run: |
df -a
bash dev/ci-velox-buildshared-centos-8.sh
- name: Export Maven path
run: |
echo "PATH=${PATH}:/usr/lib/maven/bin" >> $GITHUB_ENV
Copy link
Contributor

@PHILO-HE PHILO-HE Aug 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the docker env doesn't contain installed maven? We should have to install maven if cache is hit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can introduce an mvn wrapper script for Gluten like Spark did: https://github.com/apache/spark/blob/master/build/mvn

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can introduce an mvn wrapper script for Gluten like Spark did: https://github.com/apache/spark/blob/master/build/mvn

Yes this is just what I am thinking about. Adding a mvnw could be a general solution here. I'd revert the changes and open a issue for that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6957

- name: Run CPP unit test
run: |
cd ./cpp/build && ctest -V
Expand Down
1 change: 0 additions & 1 deletion dev/ci-velox-buildshared-centos-8.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ yum install sudo patch java-1.8.0-openjdk-devel wget -y
wget https://downloads.apache.org/maven/maven-3/3.8.8/binaries/apache-maven-3.8.8-bin.tar.gz
tar -xvf apache-maven-3.8.8-bin.tar.gz && mv apache-maven-3.8.8 /usr/lib/maven
export PATH="${PATH}:/usr/lib/maven/bin"
echo "PATH=${PATH}:/usr/lib/maven/bin" >> $GITHUB_ENV

source /opt/rh/gcc-toolset-9/enable
./dev/builddeps-veloxbe.sh --run_setup_script=OFF --enable_ep_cache=OFF --build_tests=ON \
Expand Down
Loading