[VL] Malformed CI job name #6956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhztheplayer
changed the title
PHILO-HE
reviewed
Aug 21, 2024
.github/workflows/velox_docker.yml
Outdated
| @@ -605,6 +605,9 @@ jobs: | |||
| run: | | |||
| df -a | |||
| bash dev/ci-velox-buildshared-centos-8.sh | |||
| - name: Export Maven path | |||
| run: | | |||
| echo "PATH=${PATH}:/usr/lib/maven/bin" >> $GITHUB_ENV | |||
There was a problem hiding this comment.
Seems the docker env doesn't contain installed maven? We should have to install maven if cache is hit.
There was a problem hiding this comment.
Perhaps we can introduce an mvn wrapper script for Gluten like Spark did: https://github.com/apache/spark/blob/master/build/mvn
There was a problem hiding this comment.
Perhaps we can introduce an mvn wrapper script for Gluten like Spark did: https://github.com/apache/spark/blob/master/build/mvn
Yes this is just what I am thinking about. Adding a mvnw could be a general solution here. I'd revert the changes and open a issue for that.
This reverts commit 53db9db.
zhztheplayer
changed the title
PHILO-HE
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix(moving to another thread)/__w/_temp/06ddeeec-4ccc-421b-91f8-8dad1d79e7b5.sh: line 1: mvn: command not foundin UT job when centos 8 cache is hit