[VL] enable 11-22 upstreaming velox rebase #3773
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
JkSelf
force-pushed
the
test-11-19
branch
9 times, most recently
from
4d0540f
to
02564bf
Compare
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
JkSelf
force-pushed
the
test-11-19
branch
3 times, most recently
from
9a6d8a4
to
4af499f
Compare
|
Run Gluten Clickhouse CI |
JkSelf
force-pushed
the
test-11-19
branch
4 times, most recently
from
082539a
to
b3ccc93
Compare
ep/build-velox/src/build_velox.sh
Outdated
| @@ -120,11 +120,18 @@ function compile { | |||
| COMPILE_OPTION="$COMPILE_OPTION -DVELOX_ENABLE_GCS=ON" | |||
| fi | |||
|
|
|||
| if [[ $ENABLE_TESTS == "ON" ]] || [[ $ENABLE_BENCHMARK == "ON" ]]; then | |||
There was a problem hiding this comment.
Is this part necessary? I note VELOX_ENABLE_PARSE=ON if VELOX_BUILD_TESTING or VELXO_BUILD_BENCHMARKS is ON according to CMakeLists.txt in velox. Maybe, we can try to remove this part to see CI feedback. Thanks!
There was a problem hiding this comment.
@PHILO-HE This is necessary because in Velox, VELOX_ENABLE_PARSE is set to ON by default, while in Gluten, VELOX_ENABLE_DUCKDB is set to OFF by default. Therefore, if tests are not enabled, Velox compilation will exclude DuckDB but include Parse, resulting in a compilation issue where DuckDB files cannot be found.
| if(BUILD_TESTS) | ||
| add_velox_dependency(parse::expression "${VELOX_COMPONENTS_PATH}/parse/libvelox_parse_expression.a") |
There was a problem hiding this comment.
Nit: we can just move this part into the above if branch.
zhouyuan
changed the title
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
What changes were proposed in this pull request?
How was this patch tested?
Existing UTs.