Skip to content

Commit

Permalink
Resolve comments
Browse files Browse the repository at this point in the history
  • Loading branch information
JkSelf committed Nov 27, 2023
1 parent 9941e15 commit 70e94fe
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions ep/build-velox/src/build_velox.sh
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ function compile {
fi
fi

COMPILE_OPTION="-DVELOX_ENABLE_PARQUET=ON -DVELOX_BUILD_TESTING=OFF -DVELOX_BUILD_TEST_UTILS=OFF -DVELOX_ENABLE_DUCKDB=OFF"
COMPILE_OPTION="-DVELOX_ENABLE_PARQUET=ON -DVELOX_BUILD_TESTING=OFF -DVELOX_BUILD_TEST_UTILS=OFF -DVELOX_ENABLE_DUCKDB=OFF -DVELOX_ENABLE_PARSE=OFF"
if [ $ENABLE_BENCHMARK == "ON" ]; then
COMPILE_OPTION="$COMPILE_OPTION -DVELOX_BUILD_BENCHMARKS=ON"
fi
Expand All @@ -120,12 +120,6 @@ function compile {
COMPILE_OPTION="$COMPILE_OPTION -DVELOX_ENABLE_GCS=ON"
fi

if [[ $ENABLE_TESTS == "ON" ]] || [[ $ENABLE_BENCHMARK == "ON" ]]; then
COMPILE_OPTION="$COMPILE_OPTION -DVELOX_ENABLE_PARSE=ON"
else
COMPILE_OPTION="$COMPILE_OPTION -DVELOX_ENABLE_PARSE=OFF"
fi

COMPILE_OPTION="$COMPILE_OPTION -DCMAKE_BUILD_TYPE=${BUILD_TYPE}"
COMPILE_TYPE=$(if [[ "$BUILD_TYPE" == "debug" ]] || [[ "$BUILD_TYPE" == "Debug" ]]; then echo 'debug'; else echo 'release'; fi)
echo "COMPILE_OPTION: "$COMPILE_OPTION
Expand Down

0 comments on commit 70e94fe

Please sign in to comment.