[#643] improvement(core): Improve and fix the possible concurrent problem when visiting EntityStore #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage Report
Files
|
jerryshao
reviewed
Nov 2, 2023
core/src/main/java/com/datastrato/gravitino/storage/kv/KvEntityStore.java
Outdated
Show resolved
Hide resolved
qqqttt123
reviewed
Nov 2, 2023
| Assertions.assertEquals(9, totalFailed); | ||
|
|
||
| } finally { | ||
| FileUtils.deleteDirectory(FileUtils.getFile("/tmp/testConcurrentIssues")); |
There was a problem hiding this comment.
Could we use the TempDir of Junit here? We don't need care the deletion of the file if we use TempDir.
|
The current change LGTM. @qqqttt123 do you have any more comment? |
jerryshao
approved these changes
Nov 3, 2023
qqqttt123
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Introducing the
reentrantReadWriteLockto alleviate possible concurrent problems to access theKvEntityStoreWhy are the changes needed?
KvEntityStoresubjects to concurrent problems when multi-thread access it at the same time. For instance, if there aremultiple threads are attempting to save the entity with the same name identifier into the store. We must ensure that the entity can only be saved successfully once.
Fix: #643
Fix: #618
Does this PR introduce any user-facing change?
No
How was this patch tested?
New test case named
testConcurrentIssuesinTestKvEntityStorageadded.