Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] NameMapping related operations should also be guarded by Read/write lock in KvEntityStore #681

Closed
yuqi1129 opened this issue Nov 6, 2023 · 1 comment
Closed

[Improvement] NameMapping related operations should also be guarded by Read/write lock in KvEntityStore #681

yuqi1129 opened this issue Nov 6, 2023 · 1 comment
Assignees
@yuqi1129
Labels
improvement Improvements on everything

Comments

@yuqi1129
Copy link
Contributor

yuqi1129 commented Nov 6, 2023

What would you like to be improved?

#654 resolved the issue of concurrency in the visit KV backend. However, it overlooked the name mapping service in the lock block, so this issue will attempt to address this issue.

How should we improve?

No response
@yuqi1129 yuqi1129 added the improvement Improvements on everything label Nov 6, 2023
@yuqi1129 yuqi1129 self-assigned this Nov 6, 2023
@yuqi1129 yuqi1129 changed the title [Improvement] NameMapping related operations should also be added by Read/write lock [Improvement] NameMapping related operations should also be guarded by Read/write lock in KvEntityStore Nov 6, 2023
@yuqi1129 yuqi1129 mentioned this issue Nov 6, 2023
Closed
@jerryshao jerryshao added this to the Gravitino 0.3.0 milestone Nov 20, 2023
@yuqi1129
Copy link
Contributor Author

This has been fixed

@jerryshao jerryshao removed this from the Gravitino 0.3.0 milestone Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuqi1129 yuqi1129

Labels
improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#681] improvement(core): Remove redundant lock operation in KvNameMappingService yuqi1129/graviton
2 participants
@jerryshao @yuqi1129