Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Improve the metalake/catalog drop mechanism #294

Closed
3 tasks done
jerryshao opened this issue Aug 29, 2023 · 4 comments
Closed
3 tasks done

[Improvement] Improve the metalake/catalog drop mechanism #294

jerryshao opened this issue Aug 29, 2023 · 4 comments
Assignees
Labels
improvement Improvements on everything

Comments

@jerryshao
Copy link
Contributor

jerryshao commented Aug 29, 2023

What would you like to be improved?

Currently, when we issue a request to drop a metalake or a catalog, we just simply delete the related metadata from rocksdb, I think this leaves several points that need to improve:

  1. We should make sure all sub-levels of entities cannot be accessed anymore.
  2. We should have a mechanism to clean/disable the left metadata with a defined behavior.
  3. The operation should be lightweight, this drop operation should not block for a long time.

For example, if we drop a metalake, we should make sure all catalogs under this metalake cannot be accessed anymore, and we should clean all the left catalog entities.

How should we improve?

No response

Sub tasks

@jerryshao jerryshao added the improvement Improvements on everything label Aug 29, 2023
@jerryshao
Copy link
Contributor Author

@yuqi1129 can you please work on this issue, to propose a solution to handle this problem.

@yuqi1129
Copy link
Contributor

Got

@yuqi1129 yuqi1129 self-assigned this Aug 29, 2023
@jerryshao jerryshao added this to the Graviton v0.2.0 milestone Aug 29, 2023
@yuqi1129
Copy link
Contributor

@jerryshao
I have added a new doc about refactoring the whole entity encoding plan. After viewing and thinking thoroughly, currently entity encoding plan can hardly handle deletion and renaming. So I came up with the new solution shown in the above doc.
As it's a big change and may affect the whole project, please take time to review it and do not hesitate to give your suggestions. Please forgive me as some points may be neglected due to limited time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvements on everything
Projects
None yet
Development

No branches or pull requests

2 participants