Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Subtask] Adjust id name mapping to support true deletion and modification of entiies #305

Closed
Tracked by #294
yuqi1129 opened this issue Sep 1, 2023 · 0 comments · Fixed by #309
Closed
Tracked by #294

[Subtask] Adjust id name mapping to support true deletion and modification of entiies #305

yuqi1129 opened this issue Sep 1, 2023 · 0 comments · Fixed by #309
Assignees
@yuqi1129
Milestone
Graviton v0.2.0

Comments

@yuqi1129
Copy link
Contributor

yuqi1129 commented Sep 1, 2023

Describe the subtask

  1. Current ID name mapping cannot support drop entities that have the same name in part.
  2. Renaming is also problematic and fragile

For the details, please see #294 and the docs attached to it.

Parent issue

#294
@yuqi1129 yuqi1129 mentioned this issue Sep 1, 2023
Closed
3 tasks
@yuqi1129 yuqi1129 self-assigned this Sep 1, 2023
@yuqi1129 yuqi1129 changed the title [Subtask] Adjust id name mapping to support deletion and modification of entiies really [Subtask] Adjust id name mapping to support true deletion and modification of entiies Sep 1, 2023
This was referenced Sep 1, 2023
Merged
Closed
@jerryshao jerryshao added this to the Graviton v0.2.0 milestone Sep 5, 2023
jerryshao pushed a commit that referenced this issue Sep 5, 2023
@yuqi1129
[#305][#306] improvement(core): Adjust id name mapping to support tru…
44d041e 
…e deletion and modification of entities (#309)

### What changes were proposed in this pull request?

We change the key of name-id mapping pairs.

### Why are the changes needed?

Current name-id mapping contains no namespace information and can hardly
handle the following scenarios:
- Rename an entity when there exists an entity with the same name under
a different namespace.
- Delete entities recursively.

Fix: #305 #306 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

Existing UTs can cover this change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuqi1129 yuqi1129

Labels
None yet
Projects
None yet
Milestone
Graviton v0.2.0
2 participants
@jerryshao @yuqi1129