Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Subtask] Refine deletion and update logics in the implementation of EntityStore #306

Closed
Tracked by #294
yuqi1129 opened this issue Sep 1, 2023 · 0 comments
Closed
Tracked by #294

[Subtask] Refine deletion and update logics in the implementation of EntityStore #306

yuqi1129 opened this issue Sep 1, 2023 · 0 comments
Assignees
@yuqi1129
Milestone
Graviton v0.2.0

Comments

@yuqi1129
Copy link
Contributor

yuqi1129 commented Sep 1, 2023

Describe the subtask

  1. Our update operation is not a true update, it is actually realized by deletion and insertion. What's more, updating the name of the entities and other part should be handled separately.
  2. The deletion operation is also problematic as it hasn't considered the id-name mapping relationship and does nothing about it.

In this issue, we would try to resolve those problems.

Parent issue

#294
@yuqi1129 yuqi1129 mentioned this issue Sep 1, 2023
Closed
3 tasks
@yuqi1129 yuqi1129 self-assigned this Sep 1, 2023
This was referenced Sep 4, 2023
Merged
Closed
@jerryshao jerryshao added this to the Graviton v0.2.0 milestone Sep 5, 2023
jerryshao pushed a commit that referenced this issue Sep 5, 2023
@yuqi1129
[#305][#306] improvement(core): Adjust id name mapping to support tru…
44d041e 
…e deletion and modification of entities (#309)

### What changes were proposed in this pull request?

We change the key of name-id mapping pairs.

### Why are the changes needed?

Current name-id mapping contains no namespace information and can hardly
handle the following scenarios:
- Rename an entity when there exists an entity with the same name under
a different namespace.
- Delete entities recursively.

Fix: #305 #306 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

Existing UTs can cover this change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuqi1129 yuqi1129

Labels
None yet
Projects
None yet
Milestone
Graviton v0.2.0
Development

No branches or pull requests
2 participants
@jerryshao @yuqi1129