[Fix](Column) refactor ColumnNullable to provide flags safety #40769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jerry Hu <[email protected]>
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
zclllyybb
changed the title
|
run buildall |
HappenLee
reviewed
Sep 12, 2024
HappenLee
reviewed
Sep 12, 2024
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 43231 ms |
|
run buildall |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
yiguolei
approved these changes
Sep 13, 2024
TPC-H: Total hot run time: 43015 ms |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 43007 ms |
TPC-DS: Total hot run time: 195658 ms |
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 43321 ms |
TPC-DS: Total hot run time: 195773 ms |
ClickBench: Total hot run time: 31.08 s |
BiteTheDDDDt
approved these changes
Sep 14, 2024
zclllyybb
added a commit
to zclllyybb/doris
that referenced
this pull request
Sep 14, 2024
…#40769) Issue Number: close #xxx In this pr we move null_map and relative flags to an individual base class to constrain its visibility. please reed the comment carefully test in master: ``` xxx/column_nullable_test.cpp:187: Failure Value of: null_dst->has_null() Actual: false Expected: true Error occurred in case0 [ FAILED ] ColumnNullableTest.PredicateTest (0 ms) [ RUN ] ColumnNullableTest.HashTest [ OK ] ColumnNullableTest.HashTest (0 ms) [----------] 3 tests from ColumnNullableTest (0 ms total) [----------] Global test environment tear-down [==========] 3 tests from 1 test suite ran. (1 ms total) [ PASSED ] 2 tests. [ FAILED ] 1 test, listed below: [ FAILED ] ColumnNullableTest.PredicateTest ``` and success after this pr --------- Co-authored-by: Jerry Hu <[email protected]>
zclllyybb
added a commit
to zclllyybb/doris
that referenced
this pull request
Sep 14, 2024
…#40769) Issue Number: close #xxx In this pr we move null_map and relative flags to an individual base class to constrain its visibility. please reed the comment carefully test in master: ``` xxx/column_nullable_test.cpp:187: Failure Value of: null_dst->has_null() Actual: false Expected: true Error occurred in case0 [ FAILED ] ColumnNullableTest.PredicateTest (0 ms) [ RUN ] ColumnNullableTest.HashTest [ OK ] ColumnNullableTest.HashTest (0 ms) [----------] 3 tests from ColumnNullableTest (0 ms total) [----------] Global test environment tear-down [==========] 3 tests from 1 test suite ran. (1 ms total) [ PASSED ] 2 tests. [ FAILED ] 1 test, listed below: [ FAILED ] ColumnNullableTest.PredicateTest ``` and success after this pr --------- Co-authored-by: Jerry Hu <[email protected]>
yiguolei
pushed a commit
that referenced
this pull request
Sep 14, 2024
…40769) (#40848) pick #40769 Co-authored-by: Jerry Hu <[email protected]>
HappenLee
pushed a commit
that referenced
this pull request
Sep 20, 2024
dataroaring
pushed a commit
that referenced
this pull request
Sep 26, 2024
## Proposed changes Issue Number: close #xxx In this pr we move null_map and relative flags to an individual base class to constrain its visibility. please reed the comment carefully test in master: ``` xxx/column_nullable_test.cpp:187: Failure Value of: null_dst->has_null() Actual: false Expected: true Error occurred in case0 [ FAILED ] ColumnNullableTest.PredicateTest (0 ms) [ RUN ] ColumnNullableTest.HashTest [ OK ] ColumnNullableTest.HashTest (0 ms) [----------] 3 tests from ColumnNullableTest (0 ms total) [----------] Global test environment tear-down [==========] 3 tests from 1 test suite ran. (1 ms total) [ PASSED ] 2 tests. [ FAILED ] 1 test, listed below: [ FAILED ] ColumnNullableTest.PredicateTest ``` and success after this pr --------- Co-authored-by: Jerry Hu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
In this pr we move null_map and relative flags to an individual base class to constrain its visibility.
please reed the comment carefully
test in master:
and success after this pr