-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Fix](Column) refactor ColumnNullable to provide flags safety (#40769)
## Proposed changes Issue Number: close #xxx In this pr we move null_map and relative flags to an individual base class to constrain its visibility. please reed the comment carefully test in master: ``` xxx/column_nullable_test.cpp:187: Failure Value of: null_dst->has_null() Actual: false Expected: true Error occurred in case0 [ FAILED ] ColumnNullableTest.PredicateTest (0 ms) [ RUN ] ColumnNullableTest.HashTest [ OK ] ColumnNullableTest.HashTest (0 ms) [----------] 3 tests from ColumnNullableTest (0 ms total) [----------] Global test environment tear-down [==========] 3 tests from 1 test suite ran. (1 ms total) [ PASSED ] 2 tests. [ FAILED ] 1 test, listed below: [ FAILED ] ColumnNullableTest.PredicateTest ``` and success after this pr --------- Co-authored-by: Jerry Hu <[email protected]>
- Loading branch information
Showing
9 changed files
with
426 additions
and
176 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.