Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](window_func) fix bug of agg function used in window function and add many test cases #40678

Merged
merged 3 commits into from
Sep 20, 2024
Merged

[fix](window_func) fix bug of agg function used in window function and add many test cases #40678

merged 3 commits into from
Sep 20, 2024

Conversation

jacktengg
Copy link
Contributor

@jacktengg jacktengg commented Sep 11, 2024 •
edited
Loading

Proposed changes

Support usage in window function for many agg functions by adding reset method.
Fix bug of window_funnel used in window funciton;
Fix bug of wrong result of orthogonal_bitmap_intersect.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@jacktengg jacktengg force-pushed the fix-0911-window_func branch 3 times, most recently from dba44e3 to fd3139f Compare September 11, 2024 08:45
@jacktengg
Copy link
Contributor Author

run buildall

@jacktengg jacktengg force-pushed the fix-0911-window_func branch 2 times, most recently from 5386622 to ab664e8 Compare September 14, 2024 16:15
@jacktengg jacktengg changed the title [regression](window_func) add test case for group_concat and hll_union_agg [fix](window_func) fix window_funnel bug used in window function add test cases for agg functions used in window function Sep 14, 2024
@jacktengg
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 42048 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ab664e811ea52fc56f529ffdfdf87eee1caf4007, data reload: false

------ Round 1 ----------------------------------
q1	17620	7340	7173	7173
q2	2048	155	155	155
q3	10695	1164	1270	1164
q4	10432	862	834	834
q5	7753	3099	3167	3099
q6	229	144	148	144
q7	1022	614	601	601
q8	9438	2069	2035	2035
q9	6795	6436	6431	6431
q10	7074	2331	2297	2297
q11	447	243	244	243
q12	392	213	214	213
q13	17787	2972	2954	2954
q14	251	205	211	205
q15	568	525	521	521
q16	506	425	415	415
q17	987	932	945	932
q18	7422	6870	6808	6808
q19	1386	1233	1201	1201
q20	582	286	278	278
q21	3896	3331	3380	3331
q22	1094	1014	1014	1014
Total cold run time: 108424 ms
Total hot run time: 42048 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7068	7110	7078	7078
q2	323	228	223	223
q3	3079	3057	3018	3018
q4	2035	2028	2023	2023
q5	5569	5594	5664	5594
q6	236	142	141	141
q7	2190	1799	1776	1776
q8	3315	3379	3400	3379
q9	8706	8907	8748	8748
q10	3559	3456	3534	3456
q11	573	470	482	470
q12	792	603	575	575
q13	10534	3124	3179	3124
q14	295	293	293	293
q15	565	526	525	525
q16	518	470	457	457
q17	1766	1734	1707	1707
q18	8483	8177	8111	8111
q19	1752	1750	1740	1740
q20	2097	1858	1903	1858
q21	5413	5261	5442	5261
q22	1099	1034	1046	1034
Total cold run time: 69967 ms
Total hot run time: 60591 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.30% (9575/25672)
Line Coverage: 28.69% (79110/275742)
Region Coverage: 28.17% (40957/145381)
Branch Coverage: 24.80% (20882/84186)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ab664e811ea52fc56f529ffdfdf87eee1caf4007_ab664e811ea52fc56f529ffdfdf87eee1caf4007/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 197483 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ab664e811ea52fc56f529ffdfdf87eee1caf4007, data reload: false

query1	1287	874	907	874
query2	6400	1722	1791	1722
query3	10796	3963	3880	3880
query4	54702	25819	23886	23886
query5	5137	506	507	506
query6	407	164	164	164
query7	5744	310	293	293
query8	269	226	218	218
query9	6699	2553	2528	2528
query10	427	296	287	287
query11	16860	15469	15665	15469
query12	150	97	96	96
query13	1464	420	390	390
query14	10666	6748	6569	6569
query15	195	186	167	167
query16	6979	461	498	461
query17	1149	597	608	597
query18	1747	317	318	317
query19	197	153	155	153
query20	119	112	109	109
query21	223	110	102	102
query22	4614	4377	4654	4377
query23	34837	33660	33700	33660
query24	6117	3059	3058	3058
query25	511	407	408	407
query26	621	158	162	158
query27	1593	290	294	290
query28	2843	2066	2041	2041
query29	677	431	424	424
query30	232	149	150	149
query31	978	757	800	757
query32	80	53	56	53
query33	448	296	306	296
query34	896	485	469	469
query35	897	736	732	732
query36	1042	896	867	867
query37	135	80	78	78
query38	3964	3873	3973	3873
query39	1458	1397	1376	1376
query40	205	98	99	98
query41	50	52	47	47
query42	120	98	95	95
query43	496	453	444	444
query44	1192	783	785	783
query45	195	164	176	164
query46	1089	827	807	807
query47	1898	1758	1796	1758
query48	430	354	368	354
query49	692	409	410	409
query50	942	439	444	439
query51	7145	6931	6921	6921
query52	95	89	86	86
query53	256	181	184	181
query54	561	444	460	444
query55	78	74	77	74
query56	286	252	276	252
query57	1191	1050	1066	1050
query58	230	261	232	232
query59	2850	2717	2567	2567
query60	302	269	280	269
query61	104	100	114	100
query62	788	672	666	666
query63	215	185	189	185
query64	1389	651	651	651
query65	3217	3199	3201	3199
query66	677	295	298	295
query67	15910	15542	15222	15222
query68	1454	590	580	580
query69	458	294	298	294
query70	1184	1114	1130	1114
query71	358	281	280	280
query72	6218	3960	4079	3960
query73	761	341	336	336
query74	9449	8983	9124	8983
query75	3389	2682	2747	2682
query76	1402	1229	1216	1216
query77	495	299	296	296
query78	10054	9416	9349	9349
query79	1098	870	861	861
query80	860	592	562	562
query81	473	236	232	232
query82	1269	197	192	192
query83	242	208	152	152
query84	289	97	107	97
query85	751	371	360	360
query86	366	322	310	310
query87	4482	4277	4295	4277
query88	4048	4006	3977	3977
query89	388	357	367	357
query90	1833	302	296	296
query91	160	168	163	163
query92	77	80	76	76
query93	1133	980	995	980
query94	780	347	379	347
query95	476	425	415	415
query96	462	460	461	460
query97	3186	3098	3103	3098
query98	227	221	230	221
query99	1667	1318	1315	1315
Total cold run time: 295652 ms
Total hot run time: 197483 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.79 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ab664e811ea52fc56f529ffdfdf87eee1caf4007, data reload: false

query1	0.05	0.05	0.04
query2	0.06	0.02	0.02
query3	0.23	0.06	0.06
query4	1.66	0.09	0.09
query5	0.51	0.49	0.49
query6	1.16	0.72	0.72
query7	0.02	0.02	0.02
query8	0.03	0.03	0.03
query9	0.56	0.50	0.53
query10	0.57	0.58	0.57
query11	0.13	0.10	0.10
query12	0.13	0.11	0.11
query13	0.60	0.59	0.59
query14	1.41	1.45	1.48
query15	0.88	0.84	0.84
query16	0.38	0.37	0.38
query17	1.04	1.03	1.02
query18	0.18	0.18	0.19
query19	1.86	1.86	1.82
query20	0.01	0.01	0.02
query21	15.39	0.57	0.55
query22	2.95	4.09	3.18
query23	17.64	1.00	1.13
query24	2.35	0.37	0.38
query25	0.32	0.10	0.03
query26	0.17	0.14	0.14
query27	0.05	0.03	0.03
query28	12.02	1.02	0.98
query29	12.62	3.23	3.25
query30	0.26	0.05	0.06
query31	2.89	0.38	0.37
query32	3.30	0.46	0.46
query33	2.97	3.04	3.00
query34	15.44	4.30	4.29
query35	4.32	4.32	4.31
query36	0.70	0.48	0.48
query37	0.08	0.05	0.06
query38	0.05	0.03	0.03
query39	0.03	0.02	0.02
query40	0.17	0.13	0.12
query41	0.08	0.02	0.03
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 105.33 s
Total hot run time: 31.79 s

@jacktengg jacktengg force-pushed the fix-0911-window_func branch 2 times, most recently from 511e455 to 1484a7a Compare September 17, 2024 14:39
@jacktengg jacktengg changed the title [fix](window_func) fix window_funnel bug used in window function add test cases for agg functions used in window function [fix](window_func) fix window_funnel bug used in window function Sep 17, 2024
@jacktengg
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 41709 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1484a7a2671a1144cb914e3e5ae3416969dbd3df, data reload: false

------ Round 1 ----------------------------------
q1	17744	7336	7273	7273
q2	2057	169	175	169
q3	10663	1101	1178	1101
q4	10462	817	737	737
q5	7766	3105	3075	3075
q6	242	155	149	149
q7	1006	636	632	632
q8	9426	2085	2081	2081
q9	6837	6408	6406	6406
q10	6996	2281	2263	2263
q11	442	256	252	252
q12	410	217	219	217
q13	17791	2990	3007	2990
q14	231	228	206	206
q15	581	528	527	527
q16	683	611	610	610
q17	990	852	853	852
q18	7359	6687	6732	6687
q19	1398	1088	1073	1073
q20	583	282	284	282
q21	4005	3210	3135	3135
q22	1077	1047	992	992
Total cold run time: 108749 ms
Total hot run time: 41709 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7256	7282	7288	7282
q2	321	229	235	229
q3	3101	2947	2956	2947
q4	1996	1847	1877	1847
q5	5618	5613	5604	5604
q6	232	149	148	148
q7	2188	1799	1754	1754
q8	3338	3447	3454	3447
q9	8722	8958	8783	8783
q10	3561	3396	3447	3396
q11	582	488	481	481
q12	795	650	602	602
q13	10284	3179	3166	3166
q14	310	282	299	282
q15	571	537	534	534
q16	714	680	706	680
q17	1804	1584	1583	1583
q18	8367	7755	7735	7735
q19	1760	1670	1362	1362
q20	2107	1880	1893	1880
q21	5582	5339	5189	5189
q22	1102	1044	1053	1044
Total cold run time: 70311 ms
Total hot run time: 59975 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.30% (9572/25661)
Line Coverage: 28.68% (79051/275652)
Region Coverage: 28.17% (40954/145367)
Branch Coverage: 24.81% (20878/84168)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1484a7a2671a1144cb914e3e5ae3416969dbd3df_1484a7a2671a1144cb914e3e5ae3416969dbd3df/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 199172 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1484a7a2671a1144cb914e3e5ae3416969dbd3df, data reload: false

query1	1303	912	895	895
query2	6412	2039	2045	2039
query3	10796	4040	4045	4040
query4	62484	28752	23378	23378
query5	5163	463	479	463
query6	394	163	168	163
query7	5418	296	294	294
query8	299	212	217	212
query9	8154	2677	2654	2654
query10	441	292	280	280
query11	17464	15207	15727	15207
query12	155	104	94	94
query13	1447	425	414	414
query14	10545	7591	7525	7525
query15	215	180	177	177
query16	6823	497	476	476
query17	1158	573	575	573
query18	1579	296	310	296
query19	211	142	156	142
query20	118	112	109	109
query21	223	103	103	103
query22	4581	4625	4563	4563
query23	34561	33771	33850	33771
query24	6072	2910	2876	2876
query25	478	375	378	375
query26	633	157	156	156
query27	1648	282	284	282
query28	4105	2466	2416	2416
query29	640	412	403	403
query30	232	150	153	150
query31	980	741	805	741
query32	67	49	51	49
query33	440	291	270	270
query34	919	486	491	486
query35	844	706	711	706
query36	1049	958	941	941
query37	145	90	85	85
query38	3957	3873	3933	3873
query39	1445	1423	1372	1372
query40	216	92	130	92
query41	46	49	45	45
query42	123	96	95	95
query43	518	485	492	485
query44	1169	818	795	795
query45	191	160	168	160
query46	1119	787	749	749
query47	1889	1766	1805	1766
query48	475	385	360	360
query49	680	377	368	368
query50	832	415	407	407
query51	7096	6957	6872	6872
query52	94	87	89	87
query53	245	180	174	174
query54	584	464	457	457
query55	75	79	78	78
query56	271	243	264	243
query57	1215	1091	1066	1066
query58	214	243	246	243
query59	3121	3030	2875	2875
query60	303	273	264	264
query61	106	97	99	97
query62	768	661	672	661
query63	204	190	183	183
query64	1387	653	673	653
query65	3260	3214	3197	3197
query66	681	293	304	293
query67	15924	15543	15517	15517
query68	1255	873	853	853
query69	430	341	354	341
query70	1147	1105	1177	1105
query71	333	337	328	328
query72	4582	3427	3405	3405
query73	592	582	578	578
query74	9201	8977	8901	8901
query75	2957	2917	2867	2867
query76	1038	878	868	868
query77	369	352	382	352
query78	9430	9312	9577	9312
query79	912	907	862	862
query80	603	577	576	576
query81	443	251	253	251
query82	228	226	231	226
query83	164	162	150	150
query84	206	100	102	100
query85	664	446	459	446
query86	339	328	324	324
query87	4393	4366	4300	4300
query88	4198	4062	4040	4040
query89	369	360	358	358
query90	1114	319	312	312
query91	169	183	158	158
query92	75	74	72	72
query93	899	885	890	885
query94	481	364	391	364
query95	428	426	415	415
query96	482	484	483	483
query97	3179	3111	3143	3111
query98	242	225	223	223
query99	1313	1301	1275	1275
Total cold run time: 298639 ms
Total hot run time: 199172 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.62 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1484a7a2671a1144cb914e3e5ae3416969dbd3df, data reload: false

query1	0.05	0.04	0.04
query2	0.06	0.02	0.03
query3	0.23	0.06	0.06
query4	1.63	0.10	0.10
query5	0.51	0.51	0.52
query6	1.13	0.73	0.72
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.55	0.51	0.49
query10	0.55	0.55	0.54
query11	0.14	0.11	0.11
query12	0.14	0.10	0.10
query13	0.61	0.60	0.59
query14	2.96	3.03	3.09
query15	0.89	0.83	0.82
query16	0.39	0.38	0.39
query17	1.00	1.06	1.02
query18	0.19	0.20	0.19
query19	1.89	1.76	2.02
query20	0.01	0.01	0.02
query21	15.36	0.59	0.60
query22	2.26	2.72	2.04
query23	17.26	0.83	0.87
query24	3.19	1.47	1.67
query25	0.28	0.11	0.08
query26	0.54	0.13	0.14
query27	0.05	0.03	0.04
query28	9.68	1.11	1.07
query29	12.58	3.34	3.33
query30	0.25	0.06	0.06
query31	2.89	0.39	0.38
query32	3.25	0.48	0.46
query33	2.99	3.02	3.02
query34	16.74	4.46	4.39
query35	4.42	4.41	4.45
query36	0.69	0.49	0.51
query37	0.08	0.06	0.06
query38	0.04	0.03	0.03
query39	0.03	0.02	0.02
query40	0.16	0.13	0.12
query41	0.07	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.87 s
Total hot run time: 33.62 s

@jacktengg jacktengg changed the title [fix](window_func) fix window_funnel bug used in window function [fix](window_func) fix window_funnel bug used in window function and add many test cases Sep 19, 2024
@jacktengg
Copy link
Contributor Author

run buildall

@jacktengg jacktengg force-pushed the fix-0911-window_func branch 2 times, most recently from 69ae6cf to 1640416 Compare September 19, 2024 02:22
@jacktengg
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 41756 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 16404168a6f940cab017dd714a733bb497b58c64, data reload: false

------ Round 1 ----------------------------------
q1	17569	7409	7243	7243
q2	2052	166	160	160
q3	10864	1096	1244	1096
q4	10224	756	736	736
q5	7734	3116	3103	3103
q6	236	150	149	149
q7	1017	614	607	607
q8	9426	2069	2085	2069
q9	6904	6481	6472	6472
q10	7011	2319	2319	2319
q11	446	254	253	253
q12	415	215	228	215
q13	17798	3006	2944	2944
q14	248	219	215	215
q15	578	514	526	514
q16	696	630	615	615
q17	1008	855	866	855
q18	7393	6601	6784	6601
q19	1412	1056	1145	1056
q20	592	290	284	284
q21	4098	3232	3300	3232
q22	1136	1020	1018	1018
Total cold run time: 108857 ms
Total hot run time: 41756 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7225	7274	7273	7273
q2	333	237	229	229
q3	3089	2982	2951	2951
q4	2021	1857	1811	1811
q5	5625	5611	5676	5611
q6	238	145	147	145
q7	2217	1792	1787	1787
q8	3346	3448	3458	3448
q9	8782	9011	8881	8881
q10	3530	3441	3491	3441
q11	600	486	492	486
q12	813	577	607	577
q13	10451	3147	3219	3147
q14	312	277	263	263
q15	583	514	516	514
q16	717	688	698	688
q17	1821	1612	1554	1554
q18	8223	7718	7811	7718
q19	1753	1592	1584	1584
q20	2169	1913	1892	1892
q21	5475	5341	5551	5341
q22	1112	1074	1017	1017
Total cold run time: 70435 ms
Total hot run time: 60358 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 199414 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 16404168a6f940cab017dd714a733bb497b58c64, data reload: false

query1	1302	889	871	871
query2	6343	2067	2024	2024
query3	10815	3969	4020	3969
query4	62829	29598	23589	23589
query5	5174	472	471	471
query6	387	162	168	162
query7	5416	299	304	299
query8	301	221	223	221
query9	8715	2682	2649	2649
query10	437	309	283	283
query11	17649	15184	15819	15184
query12	150	108	103	103
query13	1471	420	411	411
query14	10419	7144	7192	7144
query15	215	170	179	170
query16	6758	488	518	488
query17	1184	613	587	587
query18	1503	302	302	302
query19	212	153	147	147
query20	124	109	121	109
query21	216	108	103	103
query22	4661	4513	4886	4513
query23	34640	34058	34034	34034
query24	5976	2928	2854	2854
query25	498	394	402	394
query26	667	158	159	158
query27	1666	286	285	285
query28	4003	2478	2435	2435
query29	673	426	422	422
query30	231	153	158	153
query31	981	759	795	759
query32	71	54	53	53
query33	419	286	285	285
query34	915	482	487	482
query35	838	741	739	739
query36	1055	931	926	926
query37	147	87	85	85
query38	4014	3951	4019	3951
query39	1468	1427	1392	1392
query40	211	98	93	93
query41	50	47	48	47
query42	113	97	98	97
query43	532	505	495	495
query44	1157	814	782	782
query45	192	166	161	161
query46	1115	766	744	744
query47	1926	1800	1824	1800
query48	468	363	367	363
query49	692	409	423	409
query50	837	404	419	404
query51	7145	6882	6972	6882
query52	101	89	84	84
query53	252	174	179	174
query54	563	449	450	449
query55	77	74	74	74
query56	264	243	259	243
query57	1193	1102	1076	1076
query58	215	222	261	222
query59	3209	3041	2841	2841
query60	302	261	262	261
query61	102	105	101	101
query62	762	658	666	658
query63	216	182	188	182
query64	1340	629	635	629
query65	3266	3182	3211	3182
query66	681	299	303	299
query67	16051	15534	15630	15534
query68	1300	855	839	839
query69	431	340	336	336
query70	1146	1166	1186	1166
query71	336	335	335	335
query72	6002	3479	3396	3396
query73	587	583	571	571
query74	9094	8961	9044	8961
query75	2889	2951	2968	2951
query76	1053	862	855	855
query77	404	354	358	354
query78	9574	9319	9296	9296
query79	907	899	872	872
query80	595	561	579	561
query81	463	251	248	248
query82	235	227	233	227
query83	162	156	160	156
query84	250	107	100	100
query85	668	382	358	358
query86	298	316	316	316
query87	4399	4255	4379	4255
query88	4288	4094	4057	4057
query89	370	356	366	356
query90	1330	311	310	310
query91	165	163	163	163
query92	72	72	75	72
query93	917	905	907	905
query94	525	365	358	358
query95	419	416	408	408
query96	493	490	487	487
query97	3128	3150	3147	3147
query98	227	234	217	217
query99	1451	1325	1289	1289
Total cold run time: 301753 ms
Total hot run time: 199414 ms

@jacktengg
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 41680 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit dc4125b62a6a6b301814e4b6637a8c15e33cda0a, data reload: false

------ Round 1 ----------------------------------
q1	17771	7518	7273	7273
q2	2050	176	166	166
q3	10684	1099	1232	1099
q4	10350	704	747	704
q5	7754	3149	3099	3099
q6	237	154	151	151
q7	1031	629	600	600
q8	9451	2096	2072	2072
q9	6954	6400	6448	6400
q10	7008	2284	2283	2283
q11	435	253	258	253
q12	415	219	225	219
q13	17792	2957	2998	2957
q14	240	214	226	214
q15	570	511	530	511
q16	668	601	603	601
q17	992	832	773	773
q18	7505	6701	6891	6701
q19	1432	1059	1051	1051
q20	596	296	282	282
q21	4121	3296	3273	3273
q22	1114	1016	998	998
Total cold run time: 109170 ms
Total hot run time: 41680 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7236	7204	7197	7197
q2	322	236	230	230
q3	3054	3004	2968	2968
q4	2081	1875	1796	1796
q5	5588	5595	5724	5595
q6	233	147	146	146
q7	2201	1789	1830	1789
q8	3344	3480	3445	3445
q9	8808	8948	8802	8802
q10	3495	3438	3518	3438
q11	582	496	476	476
q12	853	679	604	604
q13	10514	3166	3147	3147
q14	304	271	275	271
q15	573	541	528	528
q16	732	679	683	679
q17	1801	1622	1610	1610
q18	8304	7855	7794	7794
q19	1903	1438	1750	1438
q20	2136	1871	1900	1871
q21	5531	5226	5414	5226
q22	1163	1071	1027	1027
Total cold run time: 70758 ms
Total hot run time: 60077 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.29% (9586/25705)
Line Coverage: 28.70% (79219/276067)
Region Coverage: 28.16% (41020/145655)
Branch Coverage: 24.79% (20903/84304)
Coverage Report: http://coverage.selectdb-in.cc/coverage/dc4125b62a6a6b301814e4b6637a8c15e33cda0a_dc4125b62a6a6b301814e4b6637a8c15e33cda0a/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 195373 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit dc4125b62a6a6b301814e4b6637a8c15e33cda0a, data reload: false

query1	1275	863	895	863
query2	6407	2123	2043	2043
query3	10763	3882	3950	3882
query4	63503	26823	23478	23478
query5	5200	479	460	460
query6	398	176	172	172
query7	5489	298	293	293
query8	308	223	219	219
query9	8473	2635	2654	2635
query10	473	294	277	277
query11	18001	15101	15807	15101
query12	157	113	115	113
query13	1465	414	406	406
query14	10284	7581	7563	7563
query15	205	177	178	177
query16	7029	512	477	477
query17	1227	584	590	584
query18	1764	309	319	309
query19	207	153	153	153
query20	122	114	120	114
query21	209	101	104	101
query22	4847	4712	4757	4712
query23	34590	33943	33748	33748
query24	6017	2864	2904	2864
query25	514	408	406	406
query26	634	157	157	157
query27	1630	281	290	281
query28	4428	2458	2443	2443
query29	669	438	430	430
query30	237	155	152	152
query31	991	789	813	789
query32	70	58	52	52
query33	437	293	283	283
query34	888	497	487	487
query35	866	733	728	728
query36	1077	923	951	923
query37	148	88	97	88
query38	4058	3931	3940	3931
query39	1499	1422	1426	1422
query40	204	97	95	95
query41	51	49	50	49
query42	117	100	94	94
query43	523	501	491	491
query44	1148	811	795	795
query45	192	161	159	159
query46	1131	796	755	755
query47	1927	1795	1861	1795
query48	461	367	369	367
query49	699	400	388	388
query50	820	406	401	401
query51	7159	6784	6862	6784
query52	96	87	86	86
query53	250	175	181	175
query54	568	449	461	449
query55	76	75	78	75
query56	278	252	258	252
query57	1233	1100	1112	1100
query58	234	225	228	225
query59	3157	3032	2998	2998
query60	279	260	249	249
query61	100	106	104	104
query62	741	670	664	664
query63	227	185	183	183
query64	1407	627	602	602
query65	3218	3220	3199	3199
query66	663	297	321	297
query67	15816	15648	15654	15648
query68	4380	589	578	578
query69	450	300	308	300
query70	1180	1044	1111	1044
query71	348	280	271	271
query72	6400	4064	4127	4064
query73	770	324	333	324
query74	9460	8826	8913	8826
query75	3387	2601	2671	2601
query76	1683	911	914	911
query77	493	295	296	295
query78	9963	9199	9092	9092
query79	1120	558	539	539
query80	846	448	440	440
query81	521	245	239	239
query82	239	139	140	139
query83	156	133	137	133
query84	289	81	79	79
query85	911	291	272	272
query86	371	291	293	291
query87	4600	4283	4249	4249
query88	3744	2364	2349	2349
query89	397	284	280	280
query90	2107	189	189	189
query91	180	145	143	143
query92	54	45	48	45
query93	1693	540	549	540
query94	763	283	249	249
query95	353	256	255	255
query96	609	290	278	278
query97	3226	3082	3085	3082
query98	214	203	194	194
query99	1599	1299	1287	1287
Total cold run time: 311840 ms
Total hot run time: 195373 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.93 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit dc4125b62a6a6b301814e4b6637a8c15e33cda0a, data reload: false

query1	0.05	0.04	0.04
query2	0.06	0.03	0.03
query3	0.23	0.06	0.06
query4	1.65	0.10	0.10
query5	0.51	0.51	0.50
query6	1.13	0.73	0.72
query7	0.01	0.01	0.01
query8	0.04	0.03	0.03
query9	0.56	0.49	0.50
query10	0.55	0.55	0.55
query11	0.14	0.10	0.11
query12	0.13	0.11	0.11
query13	0.61	0.60	0.58
query14	3.09	2.97	3.01
query15	0.89	0.82	0.81
query16	0.39	0.40	0.39
query17	1.05	1.05	1.07
query18	0.20	0.19	0.19
query19	1.87	1.85	2.01
query20	0.01	0.01	0.01
query21	15.36	0.59	0.60
query22	2.31	1.87	2.87
query23	17.20	0.82	0.80
query24	2.86	1.28	1.15
query25	0.28	0.18	0.07
query26	0.41	0.14	0.14
query27	0.04	0.03	0.04
query28	10.48	1.09	1.06
query29	12.56	3.16	3.17
query30	0.24	0.06	0.06
query31	2.88	0.38	0.38
query32	3.28	0.48	0.46
query33	2.93	3.00	3.04
query34	17.15	4.38	4.45
query35	4.41	4.42	4.42
query36	0.69	0.48	0.47
query37	0.08	0.06	0.06
query38	0.04	0.03	0.03
query39	0.03	0.02	0.02
query40	0.16	0.13	0.12
query41	0.07	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.71 s
Total hot run time: 32.93 s

@jacktengg
Copy link
Contributor Author

run cloud_p0

@jacktengg jacktengg changed the title [fix](window_func) fix window_funnel bug used in window function and add many test cases [fix](window_func) fix bug of agg function used in window function and add many test cases Sep 20, 2024
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 11dfd19 into apache:master Sep 20, 2024
26 of 31 checks passed
jacktengg added a commit to jacktengg/incubator-doris that referenced this pull request Sep 26, 2024
@jacktengg
[fix](window_func) fix bug of agg function used in window function an…
2a2f3b1 
…d add many test cases (apache#40678)
@jacktengg jacktengg mentioned this pull request Sep 26, 2024
Merged
jacktengg added a commit to jacktengg/incubator-doris that referenced this pull request Sep 26, 2024
@jacktengg
[fix](window_func) fix bug of agg function used in window function an…
c2b3cb7 
…d add many test cases (apache#40678)
jacktengg added a commit to jacktengg/incubator-doris that referenced this pull request Sep 26, 2024
@jacktengg
[fix](window_func) fix bug of agg function used in window function an…
570f982 
…d add many test cases (apache#40678)
@jacktengg jacktengg mentioned this pull request Sep 26, 2024
Merged
jacktengg added a commit to jacktengg/incubator-doris that referenced this pull request Sep 26, 2024
@jacktengg
[fix](window_func) fix bug of agg function used in window function an…
46471c2 
…d add many test cases (apache#40678)
yiguolei pushed a commit that referenced this pull request Sep 26, 2024
@jacktengg
[fix](window_func) fix bug of agg function used in window function an…
bf3d424 
…d add many test cases (#40678) (#41328)

## Proposed changes

Issue Number: close #xxx

BP #40678
yiguolei pushed a commit that referenced this pull request Sep 27, 2024
@jacktengg
[fix](window_func) fix bug of agg function used in window function an…
354e3fb 
…d add many test cases (#40678) (#41329)

## Proposed changes

Issue Number: close #xxx

BP #40678
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiguolei yiguolei yiguolei approved these changes

@zhangstar333 zhangstar333 zhangstar333 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.7-merged dev/3.0.x reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jacktengg @doris-robot @yiguolei @zhangstar333