Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](window_funnel) fix wrong result of window_funnel #38954 #40001

Open
wants to merge 1 commit into
base: branch-2.0
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion be/src/agent/be_exec_version_manager.h
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ class BeExecVersionManager {
* 3: start from doris 2.1
* a. aggregation function do not serialize bitmap to string
*/
inline const int BeExecVersionManager::max_be_exec_version = 3;
inline const int BeExecVersionManager::max_be_exec_version = 4;
inline const int BeExecVersionManager::min_be_exec_version = 0;

} // namespace doris
16 changes: 16 additions & 0 deletions be/src/util/simd/bits.h
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,18 @@ static size_t find_byte(const std::vector<T>& vec, size_t start, T byte) {
return (T*)p - vec.data();
}

template <class T>
static size_t find_byte(const T* data, size_t start, size_t end, T byte) {
if (start >= end) {
return start;
}
const void* p = std::memchr((const void*)(data + start), byte, end - start);
if (p == nullptr) {
return end;
}
return (T*)p - data;
}

template <typename T>
bool contain_byte(const T* __restrict data, const size_t length, const signed char byte) {
return nullptr != std::memchr(reinterpret_cast<const void*>(data), byte, length);
Expand All @@ -145,6 +157,10 @@ inline size_t find_one(const std::vector<uint8_t>& vec, size_t start) {
return find_byte<uint8_t>(vec, start, 1);
}

inline size_t find_one(const uint8_t* data, size_t start, size_t end) {
return find_byte<uint8_t>(data, start, end, 1);
}

inline size_t find_zero(const std::vector<uint8_t>& vec, size_t start) {
return find_byte<uint8_t>(vec, start, 0);
}
Expand Down
51 changes: 0 additions & 51 deletions be/src/vec/aggregate_functions/aggregate_function_count_old.cpp

This file was deleted.

280 changes: 0 additions & 280 deletions be/src/vec/aggregate_functions/aggregate_function_count_old.h

This file was deleted.

Loading
Loading