[fix](window_funnel) fix wrong result of window_funnel #38954 #40001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -21,25 +21,29 @@ | |||
|
|
|||
| #pragma once | |||
|
|
|||
| #include <stddef.h> | |||
| #include <stdint.h> | |||
| #include <gen_cpp/data.pb.h> | |||
There was a problem hiding this comment.
warning: 'gen_cpp/data.pb.h' file not found [clang-diagnostic-error]
#include <gen_cpp/data.pb.h>
^| } | ||
|
|
||
| template <WindowFunnelMode WINDOW_FUNNEL_MODE> | ||
| int _get_internal() const { |
There was a problem hiding this comment.
warning: function '_get_internal' should be marked [[nodiscard]] [modernize-use-nodiscard]
Suggested change
| int _get_internal() const { | |
| [[nodiscard]] int _get_internal() const { |
| } | ||
| return max_found_event_count; | ||
| } | ||
| int get() const { |
There was a problem hiding this comment.
warning: function 'get' should be marked [[nodiscard]] [modernize-use-nodiscard]
Suggested change
| int get() const { | |
| [[nodiscard]] int get() const { |
| data->enable_mode = version >= 3; | ||
| } | ||
|
|
||
| String get_name() const override { return "window_funnel"; } |
There was a problem hiding this comment.
warning: function 'get_name' should be marked [[nodiscard]] [modernize-use-nodiscard]
Suggested change
| String get_name() const override { return "window_funnel"; } | |
| [[nodiscard]] String get_name() const override { return "window_funnel"; } |
|
|
||
| String get_name() const override { return "window_funnel"; } | ||
|
|
||
| DataTypePtr get_return_type() const override { return std::make_shared<DataTypeInt32>(); } |
There was a problem hiding this comment.
warning: function 'get_return_type' should be marked [[nodiscard]] [modernize-use-nodiscard]
Suggested change
| DataTypePtr get_return_type() const override { return std::make_shared<DataTypeInt32>(); } | |
| [[nodiscard]] DataTypePtr get_return_type() const override { return std::make_shared<DataTypeInt32>(); } |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 50112 ms |
TPC-DS: Total hot run time: 201670 ms |
ClickBench: Total hot run time: 31.55 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
gavinchou
approved these changes
Aug 27, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BP #38954