Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](mtmv) Fix some pr to 21, prs are (#39041)(#38958)(#39541) #39678

Merged
merged 5 commits into from
Aug 22, 2024
Merged

[fix](mtmv) Fix some pr to 21, prs are (#39041)(#38958)(#39541) #39678

merged 5 commits into from
Aug 22, 2024

Commits on Aug 21, 2024

  1. [fix](mtmv) Fix rewrite fail when query direct external table without… 

    … group by (apache#39041)

this is brought by apache#34185
if query external table without group by, rewrite by materialized view
will fail
such as mv def is

            select  o_custkey, o_orderdate
            from ${hive_catalog_name}.${hive_database}.${hive_table};

query is query external table directly as following, this would fail
when try to rewrte by materialized view

            select o_custkey
            from ${hive_catalog_name}.${hive_database}.${hive_table};

this pr fix the problem.
    @seawinde
    seawinde committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    2256298 View commit details
    Browse the repository at this point in the history

  2. [fix](mtmv) Fix select literal result wrongly in group by when use ma… 

    …terialized view (apache#38958)

This is brought by apache#34274

if mv def is
select o_orderdate from  orders group by o_orderdate;

query is as followiing, the result is wrong.
select 1 from orders group by o_orderdate;
    @seawinde
    seawinde committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    c365cb6 View commit details
    Browse the repository at this point in the history

  3. [improvement](mtmv) Only Generate rewritten plan when generate mv pl… 

    …an for performance (apache#39541)

Before query rewrite by materialized view, we collecet the table which
query used by method org.apache.doris.mtmv.MTMVCache#from.

In MTMVCache#from we calcute the cost of plan which is useless for
collecting table.
So add boolean needCost param in method MTMVCache#from to identify
that if need cost of plan or not for performance.
    @seawinde
    seawinde committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    89bb669 View commit details
    Browse the repository at this point in the history

  4. [fix](mtmv) Fix regression test code usage

    @seawinde
    seawinde committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    f2ec8e7 View commit details
    Browse the repository at this point in the history

  5. fix regression code

    @seawinde
    seawinde committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    f657b9b View commit details
    Browse the repository at this point in the history