[fix](mtmv) Fix some pr to 21, prs are (#39041)(#38958)(#39541) #39678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… group by (apache#39041) this is brought by apache#34185 if query external table without group by, rewrite by materialized view will fail such as mv def is select o_custkey, o_orderdate from ${hive_catalog_name}.${hive_database}.${hive_table}; query is query external table directly as following, this would fail when try to rewrte by materialized view select o_custkey from ${hive_catalog_name}.${hive_database}.${hive_table}; this pr fix the problem.
…terialized view (apache#38958) This is brought by apache#34274 if mv def is select o_orderdate from orders group by o_orderdate; query is as followiing, the result is wrong. select 1 from orders group by o_orderdate;
…an for performance (apache#39541) Before query rewrite by materialized view, we collecet the table which query used by method org.apache.doris.mtmv.MTMVCache#from. In MTMVCache#from we calcute the cost of plan which is useless for collecting table. So add boolean needCost param in method MTMVCache#from to identify that if need cost of plan or not for performance.
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
run buildall |
|
run buildall |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
pr: #39041
commitId: 2256298
pr: #38958
commitId: c365cb6
pr: #39541
commitId: 89bb669