Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix](delete command) Mark delete sign when do delete command in MoW table #35917 #38468

Merged
merged 6 commits into from
Jul 31, 2024

Commits on Jul 29, 2024

  1. [Fix](delete command) Mark delete sign when do delete command in MoW …

    …table (apache#35917)
    
    close apache#34551
    
    Problem: As shown in the issue above, if a key deleted by a delete
    statement is written to by updating only certain columns, the data will
    not display correctly.
    
    Reason: The delete statement deletes the data by writing a delete
    predicate, which is stored in the rowset meta and applied during data
    retrieval to filter the data. However, partial column updates do not
    consider the effect of the delete predicate when reading the original
    data. The imported key should be considered as a new key (since it has
    already been deleted), but it is actually treated as an old key.
    Therefore, only some columns are updated, leading to incorrect results.
    
    Solution: Consider the delete predicate during partial column updates,
    but this method will result in reading more columns, as shown in apache#35766.
    Thus, in this PR, we change the delete operation in the mow table from
    writing a delete predicate to writing a delete sign, which effectively
    resolves the issue.
    Yukang-Lian committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    8620d86 View commit details
    Browse the repository at this point in the history
  2. 2

    Yukang-Lian committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    9f762ef View commit details
    Browse the repository at this point in the history
  3. [Fix](paritial update) Fix the case of partial update failing in clou…

    …d mode (apache#37151)
    
    Problem: The `test_new_partial_update` case fails to run in cloud mode,
    but it passes in local mode.
    
    Reason: In PR apache#35917, we introduced a new table attribute
    `enable_light_delete`. When executing schema changes with `alter table
    set xxx` statements, the local and cloud modes process the logic
    differently. The cloud mode has its unique processing logic, which was
    not addressed in the mentioned PR, leading to failures in the cloud
    environment.
    
    Solution: To resolve the issue, we need to complete the missing schema
    change logic for the cloud mode. Once this is implemented, the problem
    should be resolved.
    Yukang-Lian committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    09b92c3 View commit details
    Browse the repository at this point in the history
  4. 4

    Yukang-Lian committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    bfd6ea4 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. 5

    Yukang-Lian committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    f635113 View commit details
    Browse the repository at this point in the history
  2. 6

    Yukang-Lian committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    36dd48d View commit details
    Browse the repository at this point in the history